-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Last x weeks show time range in the future #5061
Comments
@amir20 Do you have any data points that are in the future? We calculate the end of the period as your max timestamp currently |
I don't think I do. I was curious so started switching between different dates. It is weird that the time range jumps between last day, week, 14 days and 4 weeks. I think if you said is true, then I would expect the ending time to always be consistent. Here is a video recording to show what I mean. If you see, the end time keeps changing. Even more crazy last 6 hours is June 21st. Which is not true for today on June 26th. Screen.Recording.2024-06-26.at.12.10.34.PM.movLet me know if you want me to share my dashboard. |
Ah gotcha! Thanks for sharing. In your case it also looks like you are running into a double whammy as you also have timezone offset from UTC which makes it even more confusing. We are currently working on a new time range control in this PR: #4422 |
@amir20 As @mindspank mentioned, we're making changes to rationalize the labeling of these time ranges. You are seeing two separate issues:
These coming updates will resolve these UX irregularities you're witnessing. |
So my initial intuition on week ending with fixed periods was right. Isn't it confusing for I have worked on a lot of dashboards and can't recall every having last 4 weeks show data that doesn't exist yet. Even if the labeling was changed to |
@amir20 We agree with you which is why we're updating the labeling behavior to accord with your expectations. :) |
Describe the bug
When choosing
last 4 weeks
, the time range is partially in the future. For example, today is June 11th, but last 4 weeks is shown asMay 20 - June 17th
which obviously doesn't exist.To Reproduce
Steps to reproduce the behavior:
Last X period
. The bigger the range the more obviousExpected behavior
It seems like the logic is using fixed time window instead of last trailing window.
Screenshots
![Screenshot 2024-06-11 at 9 52 34 AM](https://private-user-images.githubusercontent.com/260667/338676427-4ce621be-4b9d-4f28-bdd0-55b5e7f04699.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2NDE2MjMsIm5iZiI6MTcxOTY0MTMyMywicGF0aCI6Ii8yNjA2NjcvMzM4Njc2NDI3LTRjZTYyMWJlLTRiOWQtNGYyOC1iZGQwLTU1YjVlN2YwNDY5OS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjI5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYyOVQwNjA4NDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iNmQwNzhmZWMyMTQzMTUwZTk1MjQ4OWJkOWY4MTg5Yzc4ZGI5ZjFmOWEzMmMxOTQzMTQ0N2I4ZTNjNTMyZmI4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.PoOr7qu_343JpMKK8wwBzSB_kLXPsEbF2nkmic_54QI)
Desktop (please complete the following information):
Additional context
I did a quick search and didn't find any other similar issues.
The text was updated successfully, but these errors were encountered: