Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] <AutoSaveIndicator /> throws warning for key prop #6067

Open
aliemir opened this issue Jun 21, 2024 · 0 comments · Fixed by #6064
Open

[BUG] <AutoSaveIndicator /> throws warning for key prop #6067

aliemir opened this issue Jun 21, 2024 · 0 comments · Fixed by #6064
Labels
bug Something isn't working
Milestone
July Release

Comments

@aliemir
Copy link
Member

aliemir commented Jun 21, 2024

Describe the bug

When using the auto save feature, <AutoSaveIndicator /> component from UI packages are logging errors about the usage of reserved key prop in the console. This is caused by the component itself rather than the code in the user space.

This error also causes issues when using i18nProvider to localize the message.

Steps To Reproduce

  1. Enable autoSave prop in useForm
  2. Use <AutoSaveIndicator /> or pass autoSaveProps to CRUD components.
  3. Check console to see the error

Expected behavior

<AutoSaveIndicator /> to not log any errors to the console which also causes issues when using it with i18nProvider

Packages

  • @refinedev/core
  • @refinedev/antd
  • @refinedev/mui
  • @refinedev/mantine
  • @refinedev/chakra-ui

Additional Context

Screenshot 2024-06-21 at 12 09 02
@aliemir aliemir added the bug Something isn't working label Jun 21, 2024
@aliemir aliemir mentioned this issue Jun 21, 2024
Merged
5 tasks
@aliemir aliemir linked a pull request Jun 21, 2024 that will close this issue
fix(auto-save-indicator): rename key prop to translationKey #6064
Merged
5 tasks
@aliemir aliemir added this to the July Release milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
July Release
Development

Successfully merging a pull request may close this issue.

fix(auto-save-indicator): rename key prop to translationKey refinedev/refine
1 participant
@aliemir