Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global options no longer work via rpk connect #2672

Open
trahim opened this issue Jun 20, 2024 · 2 comments
Open

Global options no longer work via rpk connect #2672

trahim opened this issue Jun 20, 2024 · 2 comments

Comments

@trahim
Copy link

trahim commented Jun 20, 2024

We have found that global options that were in the Benthos binary no longer work when calling a command.

For example this command we used to run.

docker run ghcr.io/benthosdev/benthos -c /benthos.yaml --resources '/resources/*.yaml' streams '/streams/*.yaml'

This starts fine in streams mode.
When running now with the new new redpanda image

docker run docker.redpanda.com/redpandadata/redpanda connect -c /benthos.yaml --resources '/resources/*.yaml' streams '/streams/*.yaml'

We get

Incorrect Usage: flag provided but not defined: -c

NAME:
   redpanda-connect streams - Run Redpanda Connect in streams mode

USAGE:
   redpanda-connect streams command [command options]

DESCRIPTION:
   Run Redpanda Connect in streams mode, where multiple pipelines can be executed in a
   single process and can be created, updated and removed via REST HTTP
   endpoints.

     redpanda-connect streams
     redpanda-connect -c ./root_config.yaml streams
     redpanda-connect streams ./path/to/stream/configs ./and/some/more
     redpanda-connect -c ./root_config.yaml streams ./streams/*.yaml

   In streams mode the stream fields of a root target config (input, buffer,
   pipeline, output) will be ignored. Other fields will be shared across all
   loaded streams (resources, metrics, etc).

   For more information check out the docs at:
   https://docs.redpanda.com/redpanda-connect/guides/streams_mode/about

COMMANDS:
   help, h  Shows a list of commands or help for one command

OPTIONS:
   --no-api                   Disable the HTTP API for streams mode (default: false)
   --prefix-stream-endpoints  Whether HTTP endpoints registered by stream configs should be prefixed with the stream ID (default: true)
   --help, -h                 show help

Same issues when running the streams command in help for streams above.
We have found that using the global -X flag seems to work.

docker run docker.redpanda.com/redpandadata/redpanda connect -X /benthos.yaml -X '/resources/*.yaml' streams '/streams/*.yaml'

Any idea if the plan is to use -X going forward or will the old Benthos global flags be usable again in the rpk binary?

@Jeffail
Copy link
Collaborator

Jeffail commented Jun 20, 2024

Hey @trahim, is this with the latest version of the redpanda docker container? The issue has been fixed since the first release of rpk connect, but it's possible there are still some rough edges in build artifacts.

@trahim
Copy link
Author

trahim commented Jun 21, 2024

Hey @Jeffail apologies thought I but the versions in the above but yes with the latest version: v24.1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants