Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile, linenoise language refactor #13316

Open
SoulPancake opened this issue Jun 3, 2024 · 1 comment · May be fixed by #13319
Open

Makefile, linenoise language refactor #13316

SoulPancake opened this issue Jun 3, 2024 · 1 comment · May be fixed by #13319
Labels
class:text docs and typos

Comments

@SoulPancake
Copy link

Maybe Redis should not have this language
https://github.com/redis/redis/blob/56169112e3b55e1776091964b4e510c0e1fe7110/Makefile#L1C32-L1C37

redis/deps/linenoise/linenoise.c

Line 299 in 5616911

/* Raw mode: 1960 magic shit. */

in the Makefile
@SoulPancake SoulPancake changed the title Makefile language refactor Makefile, linenoise language refactor Jun 3, 2024
@sundb
Copy link
Collaborator

sundb commented Jun 4, 2024

@SoulPancake thanks for your report, feel free to make a PR for it.

@SoulPancake SoulPancake linked a pull request Jun 4, 2024 that will close this issue
Open
@sundb sundb linked a pull request Jun 5, 2024 that will close this issue
feat: refactor language #13319
Open
@sundb sundb added the class:text docs and typos label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
class:text docs and typos
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: refactor language SoulPancake/redis
2 participants
@sundb @SoulPancake