Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedAppendOnlyFile return ASAP #13284

Open
Bannirui opened this issue May 21, 2024 · 0 comments
Open

feedAppendOnlyFile return ASAP #13284

Bannirui opened this issue May 21, 2024 · 0 comments

Comments

@Bannirui
Copy link
Contributor

Locating at:

redis/src/aof.c

Line 1340 in e92363e

if (server.aof_state == AOF_ON ||

I think it could be put at the entrance of this function, so it could be fail ASAP if AOF_OFF.

It maybe looks like as:

void feedAppendOnlyFile(int dictid, robj ** argv, int argc) {
    if (server.aof_state != AOF_ON &&
        (server.aof_state != AOF_WAIT_REWRITE || server.child_type != CHILD_TYPE_AOF))
    {
        return;
    }
    // todo
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant