Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule Request: [empty_catch] #5634

Open
2 tasks done
72A12F4E opened this issue Jun 19, 2024 · 1 comment
Open
2 tasks done

Rule Request: [empty_catch] #5634

72A12F4E opened this issue Jun 19, 2024 · 1 comment

Comments

@72A12F4E
Copy link

New Issue Checklist

New rule request

Please describe the rule idea, format
this issue's title as Rule Request: [Rule Name] and describe:

  1. Why should this rule be added? Share links to existing discussion about what
    the community thinks about this.

I think we should have a rule that triggers when someone writes a do-catch, and leaves the catch empty. Cases like this should just use try?

  1. Provide several examples of what would and wouldn't trigger violations.

Bad

do {
    try doStuff()
} catch {

}

Good

do {
    try doStuff()
} catch {
   Logger().error("\(error.localizedDescription)")
}
  1. Should the rule be configurable, if so what parameters should be configurable?

no configuration needed

  1. Should the rule be opt-in or enabled by default? Why?
    See README.md for guidelines on when to mark a rule as opt-in.

I think this should be enabled by default, although I can understand the amount of noise that might cause for existing projects.

@SimplyDanny
Copy link
Collaborator

This could become a part of the new rule introduced in #5617 or a dedicate rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants