-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing_docs warns about actors not documenting public protocol properties #5422
Comments
The reason you don't get a warning in the second case (explicitly conforming to However, I agree that the rule could know about the protocol methods an |
Hi, Can I work on this?🙂 |
Sure. Please go ahead. |
I tried to fix this. |
There is a rewrite in #5048 already, but we haven't found the time to review it. It would indeed make sense to wait for it, before this change gets added. |
OK 👍🏻 |
New Issue Checklist
Describe the bug
If you use the "actor" keyword, it implicitly conforms to the "Actor" protocol, but SwiftLint still warns about not documenting public properties from the Actor protocol. For example, if you provide a public "unownedExecutor", it warns about it not documenting it. But if you explicitly conform to "Actor" then it doesn't warn.
It seems like SwiftLint should treat actors as if they explicitly specified they conform to the "Actor" protocol.
Generates warnings
No warnings
Complete output when running SwiftLint, including the stack trace and command used
Environment
swiftlint version
to be sure)? 0.53.0Are you using nested configurations?
No
Which Xcode version are you using (check
xcodebuild -version
)?Invoking SwiftLint directly.
Do you have a sample that shows the issue?
Pasted above.
The text was updated successfully, but these errors were encountered: