@AyushAgrawal-A2 is attempting to deploy a commit to the Quadratic Team on Vercel.

A member of the Team first needs to authorize it.

@luke-quadratic @davidfig @ddimaria @davidkircos
This is ready for initial feedback. I am not sure how far I am from desired functionality.

@davidfig I wanted this also, but I was not sure about implementation. This requires a flag in schema to denote whether a row height is manually set or set by auto resize. I was unsure if I should add this boolean flag in schema or I can reuse format_rows in your running PR. Or maybe something else...? Can you please suggest schema entry for this ?

Can't you rely on undefined for row height? Once it has a value, then use that instead. Or am I missing something?

@davidfig
Auto row resizing also sets a value in SheetsOffsets and this value propagates to client and renderer ... so value is defined in both cases whether manual resize or auto.

Auto row resizing also sets a value in SheetsOffsets and this value propagates to client and renderer ... so value is defined in both cases whether manual resize or auto.

Ah, yes, you're right.

Maybe we add an auto-resize entry (which is how I think Excel does it). The easiest way would be to add an auto_size: BTreeMap<i64, f64> to Offsets. The f64 is the current size for that row/column (but changeable based on the actual content for that column/row). We then remove that entry if we manually change the size (which is stored in sizes). Alternatively, we can create an enum for sizes for size and autosize. Either way should work.

It's tricky since we have to update that autosize whenever content is changed, but we only know the wrapped size after we render it. Ideally, columns would also work this way.

This would be a bunch of work. Feel free to punt on it, and we can work toward merging this PR, and open an issue to do the autosize down the road.

This would be a bunch of work. Feel free to punt on it, and we can work toward merging this PR, and open an issue to do the autosize down the road.

@davidfig
I would try to finish this in this pr itself. I wanted to ask the schema doubt as you guy might have already planned for this. I didn't want to add random entries to schema myself.
This pr will anyways need to be refactored to incorporate changes in your Select all, column, and row #1363 pr, after it is merged in main.

This looks super nice. A few things I noticed on the functionality:

• there's a noticeable difference between the rendered text vs Monaco when wrapping. Probably has to do with the CSS vertical spacing
• the renderer is dropping characters when wrapping the text, mostly on the last line of the text
• it's auto adjusting the height after a user manually adjusted it. Once the height is changed, it should not auto-adjust unless the user double-clicks on the corner of the row heading. It should clip the text if too big instead
• the down arrow on the floating context menu is a bit large (I really like this approach)

@davidfig
all done