Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Add onnx::Gelu support for version 20 #128773

Closed
wants to merge 6 commits into from
Closed

[ONNX] Add onnx::Gelu support for version 20 #128773

wants to merge 6 commits into from

Conversation

YibinLiu666
Copy link
Contributor

@YibinLiu666 YibinLiu666 commented Jun 15, 2024 •
edited by justinchuby
Loading

Fixes #128772

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 15, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128773

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit b307e1d with merge base 99f042d (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Jun 15, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 15, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@YibinLiu666 YibinLiu666 changed the title Add onnx::Gelu support for version 20 [ONNX] Add onnx::Gelu support for version 20 Jun 15, 2024
@justinchuby justinchuby added the module: onnx Related to torch.onnx label Jun 15, 2024
@titaiwangms
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 18, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: pull / win-vs2019-cpu-py3 / build

Details for Dev Infra team Raised by workflow job

@YibinLiu666
Copy link
Contributor Author

YibinLiu666 commented Jun 19, 2024 •
edited
Loading

@pytorchbot merge

Hi~, this pr failed to merge, could you please merge it again? Thanks!

@titaiwangms
Copy link
Collaborator

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased gelu_export onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout gelu_export && git pull --rebase)

@titaiwangms titaiwangms added the topic: new features topic category label Jun 19, 2024
@titaiwangms
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-focal-rocm6.1-py3.8 / test (default, 1, 2, linux.rocm.gpu)

Details for Dev Infra team Raised by workflow job

@YibinLiu666
Copy link
Contributor Author

@pytorchbot merge

It failed again, maybe still need to trouble you to merge it again.

@titaiwangms
Copy link
Collaborator

@pytorchbot merge -f "unrelated flaky test failed on test_convolution_ops.py"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby approved these changes

@BowenBao BowenBao Awaiting requested review from BowenBao

@thiagocrepaldi thiagocrepaldi Awaiting requested review from thiagocrepaldi

@wschin wschin Awaiting requested review from wschin wschin is a code owner

@titaiwangms titaiwangms Awaiting requested review from titaiwangms titaiwangms is a code owner

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1 shubhambhokare1 is a code owner

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: new features topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ONNX export for gelu at version 20
5 participants
@YibinLiu666 @titaiwangms @pytorchmergebot @justinchuby @pytorchbot