Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profiler][inductor] put kwinputs in chrome traces #128728

Open
davidberard98 opened this issue Jun 14, 2024 · 0 comments
Open

[Profiler][inductor] put kwinputs in chrome traces #128728

davidberard98 opened this issue Jun 14, 2024 · 0 comments
Labels
oncall: profiler profiler-related issues (cpu, gpu, kineto)

Comments

@davidberard98
Copy link
Contributor

davidberard98 commented Jun 14, 2024

馃殌 The feature, motivation and pitch

use case: inductor collects this info, and it would be great if we get this in the chrome traces since we already collect it.

proposal: start off just collecting string and integer inputs.

Here is where we use the non-kwarg inputs in profiler:

torch_ops_.inputs_outputs_.push(fn.inputs());

I think this is where we put random metadata into kineto:

addMetadata("Input Dims", variantShapesToStr(arg_data.shapes));

it would be great if we can shove an arbitrary string->string dict into the op_event and then put it into the metadata in the profiler_kineto.cpp code

cc @robieta @chaekit @aaronenyeshi @guotuofeng @guyang3532 @dzhulgakov @briancoutinho @sraikund16 @sanrise @Chillee

Alternatives

No response

Additional context

No response

@davidberard98 davidberard98 added the oncall: profiler profiler-related issues (cpu, gpu, kineto) label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oncall: profiler profiler-related issues (cpu, gpu, kineto)
Projects
None yet
Development

No branches or pull requests

1 participant