Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swiglu activation function #128712

Open
PraNavKumAr01 opened this issue Jun 14, 2024 · 1 comment
Open

Add Swiglu activation function #128712

PraNavKumAr01 opened this issue Jun 14, 2024 · 1 comment
Labels
module: nn Related to torch.nn triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@PraNavKumAr01
Copy link

PraNavKumAr01 commented Jun 14, 2024

馃殌 The feature, motivation and pitch

Hey team, i love building things from scratch, and as i was implementing the LLaMa paper by meta obviously using pytorch i saw that pytorch did not have a nn.swiglu activation function. I did end up implementing it on my own, but i still feel like swiglu being used in mutliple other new language models, LLaMa being the most popler one, needs to be implemented in Pytorch and should be a part of it.

Alternatives

There are many other activation functions already in pytorch, but as results show, Swiglu has been really impactful in the success of LLaMa, so i think the community might benefit with it being in pytorch

Additional context

Also, ive been using pytorch for a long time and ive always build things from scratch, and it has always been on my todo list to contribute to pytorch, i feel like this might be it.

cc @albanD @mruberry @jbschlosser @walterddr @mikaylagawarecki

@ezyang ezyang added module: nn Related to torch.nn triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jun 15, 2024
@PraNavKumAr01
Copy link
Author

Should i start working on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: nn Related to torch.nn triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
Status: To pick up
Development

No branches or pull requests

2 participants