Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update programs to kubernetes 4.0.3 #1472

Closed
wants to merge 6 commits into from
Closed

Update programs to kubernetes 4.0.3 #1472

wants to merge 6 commits into from

Conversation

mnlumi
Copy link
Contributor

@mnlumi mnlumi commented Aug 3, 2023

Resolves #1466

@mnlumi
Copy link
Contributor Author

mnlumi commented Aug 3, 2023

@mnlumi
Copy link
Contributor Author

mnlumi commented Sep 5, 2023

@cnunciato Could you take a look at kubernetes-go-helm-wordpress? helmv2 has been removed from kubernetes v4, but updating to helmv3 and the chart version of wordpress is failing with an error.

 pulumi:pulumi:Stack (kubernetes-go-helm-wordpress-dev):
    panic: interface conversion: interface {} is nil, not *v1.Service
    goroutine 89 [running]:
    main.main.func1.1({0x0?, 0x0?})

@cnunciato cnunciato requested review from cnunciato and a team September 13, 2023 20:37
@cnunciato cnunciato added this to the 0.94 milestone Sep 14, 2023
@cnunciato cnunciato added the size/S Estimated effort to complete (1-2 days). label Sep 14, 2023
@cnunciato cnunciato self-assigned this Sep 14, 2023
@cnunciato cnunciato modified the milestones: 0.94, 0.95 Sep 30, 2023
@@ -1,57 +1,72 @@
module github.com/pulumi/examples/kubernetes-go-helm-release-wordpress

go 1.17
go 1.18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to bump this even more to the latest stable 1.21 ?

Copy link
Contributor

@desteves desteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The go version is inconsistent and quite old 1.13 at times. Looks like it was changed in some places. I'd suggest to bump them all to the latest stable version

@scottslowe scottslowe modified the milestones: 0.95, 0.96 Oct 23, 2023
@scottslowe
Copy link
Contributor

Bumping this to M96 due to Helm v3 issue described above

@scottslowe
Copy link
Contributor

scottslowe commented Oct 23, 2023

I think I have working code for this. It works as expected on EKS (after I fixed a problem with the EKS template); now testing on GKE.

Update: it's not working, the behavior persists and is a bug: pulumi/pulumi-kubernetes#2638

@mnlumi @cnunciato How would you like to proceed? Wait for a fix for the bug and update all the examples in one swoop, or update the other examples and fix this one example later?

@mnlumi
Copy link
Contributor Author

mnlumi commented Nov 1, 2023

@scottslowe At this point, the PR is now several releases behind for Kubernetes. My suggestion is to exclude the broken example while opening an issue to handle it separately.

@scottslowe
Copy link
Contributor

@mnlumi I'm good with that approach, assuming no one else has objections.

@scottslowe
Copy link
Contributor

@mnlumi Per Eric's e-mail, we'll leave this issue open to track resolution of the broken example. Just exclude the broken example from the PR to update the provider for all the rest of the examples. Once we have all tests passing, then we can merge that PR to get everything else updated.

@cnunciato cnunciato modified the milestones: 0.96, 0.97 Nov 20, 2023
@lukehoban lukehoban removed this from the 0.97 milestone Dec 20, 2023
@mnlumi
Copy link
Contributor Author

mnlumi commented Mar 22, 2024

Closing as this as it is significantly out of date and a new pull request would be more efficient. @EronWright @mjeffryes - You may want to work with your team or @cnunciato to get these kubernetes examples updated to v4 instead of v3 and the latest pulumi versions as well.

@mnlumi mnlumi closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Estimated effort to complete (1-2 days).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update kubernetes examples to use v4
5 participants