Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] When using eval command there are diff between using config option and not using config option #927

Closed
suhwan-kang opened this issue Jun 14, 2024 · 4 comments
Milestone

Comments

@suhwan-kang
Copy link
Contributor

suhwan-kang commented Jun 14, 2024

I found that if i use eval command with config option, the prompts label is disappeared.

I try to analyze why it cause and found out that there is code problem.
In deail,
main.ts -> when using config option, it use readconfigs function which is using readConfig multiple time for reading config files and do post process for each config datas.
and when not using config option, it use maybeReadConfig function which is only using readConfig onetime.
The function readConfigs's post processing has problem.
util.ts -> readConfigs has internal function seenPrompts process only prompt's id without process label.
It cause the problem that label gonna disappear when I use objects array that contain both id and label.
In result, result table miss the label option and display python code or raw prompt which did't render template variables.

Could you check it and give me a comment that whether it is intentional or not?

@typpo
Copy link
Collaborator

typpo commented Jun 14, 2024

This is not intentional - seems to be a bug. seenPrompts should take into account the label as well. Thank you for catching and analyzing this bug!

@suhwan-kang
Copy link
Contributor Author

suhwan-kang commented Jun 17, 2024

@typpo
It seems that Version 0.64.0 didn't have this bug patch.
Could you tell me when this fix is applied in release package?
I hope the bug patch is reflected in a released version.

@typpo
Copy link
Collaborator

typpo commented Jun 19, 2024

Thanks @suhwan-kang, this will be included in the next release!

@typpo typpo added this to the next milestone Jun 19, 2024
@typpo
Copy link
Collaborator

typpo commented Jun 20, 2024

released in 0.65.2

@typpo typpo closed this as completed Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants