Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ FEATURE ] : Informative feedback to the user searching for a username to connect. #13

Open
kshavp opened this issue Jun 11, 2024 · 10 comments
Labels
bug Something isn't working easy SSOC'24 Social Summer of Code 24

Comments

@kshavp
Copy link

kshavp commented Jun 11, 2024

Is your feature request related to a problem? Please describe.
The feedback from the application that the username does not exist should be informative to the user, thus we can show some "user not found" related feedback instead of what we see in the attached media.

Describe the solution you'd like
We can have a toast/popup/alert component to show the feedback.

image

@princekhunt I'd like to implement this feature under SSOC

@princekhunt
Copy link
Owner

So you'll show toast on each keystroke or on final hit ?

@kshavp
Copy link
Author

kshavp commented Jun 11, 2024

The final hit of course, the mechanism will be same as it is working now, I'll just show a toast if the user does not exist when the button is clicked.

@princekhunt
Copy link
Owner

princekhunt commented Jun 11, 2024

Button is set to be disabled till a valid username (of friend) is entered.

You can enable it, and show toast if, a username is not valid.
is this your solution ?

@kshavp
Copy link
Author

kshavp commented Jun 11, 2024

Yes, this is because the button is disabled at the client level, using disabled attribute, which can be easily removed using inspect element and thus this creates a vulnerability.

Thus, for now even if the button is disabled, it is not enough to stop the user. Have a look on the attached media, I have performed a search after removing the disabled attribute manually.

image

Thus we can possibly avoid this.

@princekhunt
Copy link
Owner

Got it.

@princekhunt princekhunt added SSOC'24 Social Summer of Code 24 bug Something isn't working labels Jun 11, 2024
@princekhunt
Copy link
Owner

Any update ?

@kshavp
Copy link
Author

kshavp commented Jun 15, 2024

I'm enhancing my current validations as I found something more critical:
image

If someone bypasses the add button without actually entering anything, it reveals a few backend side properties.

@princekhunt
Copy link
Owner

Because you're running development server with DEBUG=True in settings.
Could you check the same behaviour on production at https://privateping.bytespot.tech ?

@kshavp
Copy link
Author

kshavp commented Jun 15, 2024

image
In production i guess its safe.

@princekhunt
Copy link
Owner

Kindly make PR before End of the day, else issue will be open to all to be assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easy SSOC'24 Social Summer of Code 24
Projects
None yet
Development

No branches or pull requests

2 participants