Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When caching adapters, cache the adapter ID + the API token pair #479

Open
noyoshi opened this issue May 20, 2024 · 4 comments
Open

When caching adapters, cache the adapter ID + the API token pair #479

noyoshi opened this issue May 20, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@noyoshi
Copy link
Collaborator

noyoshi commented May 20, 2024

Feature request

When we cache adapters, we should cache the adapter ID + the API token pair. Even if the adapter is already on GPU memory, we should ensure that the caller has access to it by maintaining a cache of adapter ID + api token pairs.

Motivation

Otherwise, we could get situations where one users calls prompt w/ a private HF hub adapter and HF key, it works and is cached, then another user could call prompt w/ the same adapter without setting a HF api token in the request. Since the adapter is cached, the request works.

Your contribution

I can try to implement it, but I am quite busy so not sure when I can get to it.

@tgaddair tgaddair added enhancement New feature or request good first issue Good for newcomers labels May 20, 2024
@safimuhammad
Copy link

hello, I would like to work on this.

@magdyksaleh
Copy link
Collaborator

Hey @safimuhammad - wanna chat on discord for next steps on this?

@safimuhammad
Copy link

safimuhammad commented May 24, 2024

@magdyksaleh Sure, here's my discord user name msafi38

@safimuhammad
Copy link

hey @magdyksaleh , reaching you out on discord, lets discuss next steps on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants