fix: query config value must be converted to dict #1016
Conversation
|
@neelasha23, please review this and check the CI I took a brief look and it seems like it's an issue with the DuckDB version (an update probably broke things) |
|
OK for me to help fix things with some guidance, but prbly better on a separate branch? |
|
I added a basic sqlite connection in the format mentioned and it worked. I have fixed most of the CI issues except one. Please take a look at the changes here:
I still see this test failing: Thoughts? @edublancas |
| @@ -29,6 +30,25 @@ | |||
| ] | |||
|
|
|||
|
|
|||
| def _section_as_url_dict(section): | |||
There was a problem hiding this comment.
Please change the name to something more generic, maybe _parse_section
|
@neelasha23 I've merged your PR to fix the CI @wimvanleuven feel free to rebase so you get the CI fixes
yeah we can add an xfail and open an issue, we can tackle it later yes, I think we should add an example to the docs |
to be usable by URL.create()
Describe your changes
The fix mainly isolates the parsing of a configuration section in a separate function, so that in can be reused at the points where URL.create(**section) is called.
The parsing mainly ensure that a query attributed is also correctly converted to a dictionary or something else by parsing the value as a python string.
This seemed the least impactful change, while fixing the bugs related to the query parameter.
Issue number
Closes #1015
Checklist before requesting a review
pkgmt format馃摎 Documentation preview 馃摎: https://jupysql--1016.org.readthedocs.build/en/1016/