Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for depositing individual submissions #77

Open
jonasraoni opened this issue Feb 23, 2023 · 0 comments
Open

Drop support for depositing individual submissions #77

jonasraoni opened this issue Feb 23, 2023 · 0 comments
Assignees
Labels
Milestone

Comments

@jonasraoni
Copy link
Collaborator

jonasraoni commented Feb 23, 2023

Besides depositing full issues, the plugin also supports depositing individual submissions, which depends on the value of the object_type setting.

Problem:

  • The setting isn't configurable, and its default value is to deposit issues. Therefore, it's basically alive just to support a legacy workflow, which will end up not being well tested and lead to zombie code.
  • The current implementation attempts to group submissions in groups of 20 for each deposit. If the threshold isn't met, the deposit will never be created.

Notes:

  • At the Preservation Network there are currently 571 deposits out of 137790 (0.4%), that perhaps are using this setting (they have neither an issue nor a volume number).
  • Dropping this code will also allow merging the database entities of the plugin into a single one.
  • This task should also cover the Drop "PublishedArticle" from the getObjectType() #63
@jonasraoni jonasraoni added this to the 3.0.0 milestone Feb 23, 2023
@jonasraoni jonasraoni self-assigned this Feb 23, 2023
@jonasraoni jonasraoni modified the milestones: 3.0.0-0, 3.0.0-1 Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

1 participant