-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]if viewing a board and then creating a pin, automatically select that board in the new pins board list. #256
Comments
Hi, If you want to hide both the Pin and the board, you should set the board as private and Pins in the board as private (But you could never affect the Pin which you don't owned). Even in this case, privacy option for board also has its sense: you could hide your own collection as you wish. This is the point currently, If you have any better idea, please send a PR or we could have more discussion. |
I see. |
It make sense and thanks for your advice. |
That would be great, thankyou. And a couple more suggestions if you don't mind: Thanks again. |
The second one is nice to have while I'm not sure about the first one. Some strange URL has too many unexpected arguments (for exampel useless query string but we don't know whether it is useless), We have no silver bullets for this and I don't want the URL grows day by day. Do you have any better idea? |
Well, I was trying to pin some facebook image URLs a few days ago which didn't work due to the URLs being over 256 bytes. |
Length change has been done, you could update your source code right now or docker image later after the automatic building done. Another one will be done once I have time. |
Amazing, thank you! |
I just updated my docker image, and it appears the 256 character limit is still in place? |
Sorry, migrations should be done by hand.
|
I then stopped and restarted the container. To make sure the migration did work, I tried your instructions again and it reported "No migrations to apply.". |
Thanks for your feedback, the url length limit also exists in frontend. Please wait for latest docker-build or build it by yourself then restart your container, it will work. Please contact me if you have any problem. |
Perfect! Confirmed it works at longer lengths. |
Hi all,
So just added a pin to a private board, but im finding that the pin is still visible when not logged in (its not private).
If pins on a board don't adapt the privacy option of the board, what is the point of having the board privacy option?
Thanks.
The text was updated successfully, but these errors were encountered: