variable: support tidb_schema_cache_size reasonable range #54035
Conversation
Signed-off-by: lilinghai <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-tests-checked
release-note-none
size/XS
|
Hi @lilinghai. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54035 +/- ##
=================================================
- Coverage 72.8706% 55.6084% -17.2623%
=================================================
Files 1521 1642 +121
Lines 435164 611587 +176423
=================================================
+ Hits 317107 340094 +22987
- Misses 98499 248238 +149739
- Partials 19558 23255 +3697
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: lilinghai <[email protected]>
ti-chi-bot
bot
added
size/L
|
/retest |
|
@lilinghai: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
lilinghai
changed the title
Signed-off-by: lilinghai <[email protected]>
| require.Equal(t, schemaCacheSize.Value, strconv.Itoa(DefTiDBSchemaCacheSize)) | ||
|
|
||
| // MinValue is 512 MB | ||
| err = mock.SetGlobalSysVar(context.Background(), TiDBSchemaCacheSize, strconv.FormatUint(100*mb, 10)) |
There was a problem hiding this comment.
Please test 512MB-1 and MaxValue + 1
| @@ -1595,7 +1596,8 @@ var ( | |||
| IgnoreInlistPlanDigest = atomic.NewBool(DefTiDBIgnoreInlistPlanDigest) | |||
| TxnEntrySizeLimit = atomic.NewUint64(DefTiDBTxnEntrySizeLimit) | |||
|
|
|||
| SchemaCacheSize = atomic.NewInt64(DefTiDBSchemaCacheSize) | |||
| SchemaCacheSize = atomic.NewUint64(DefTiDBSchemaCacheSize) | |||
| SchemaCacheSizeOriginText = atomic.NewString(strconv.Itoa(DefTiDBSchemaCacheSize)) | |||
There was a problem hiding this comment.
We can get the text from SchemaCacheSize like we have done for TiDBServerMemoryLimitSessMinSize
There was a problem hiding this comment.
This value is used to store the content set by the user. For example, if the user sets 1GB, then the display for user queries will also be 1GB, not 1,073,741,824. However, the TiDBServerMemoryLimitSessMinSize will display the value as an integer to the user.
mysql> set @@global.tidb_server_memory_limit_sess_min_size='1GB';
Query OK, 0 rows affected (0.01 sec)
mysql> select @@global.tidb_server_memory_limit_sess_min_size;
+-------------------------------------------------+
| @@global.tidb_server_memory_limit_sess_min_size |
+-------------------------------------------------+
| 1073741824 |
+-------------------------------------------------+
1 row in set (0.00 sec)
mysql> set @@global.tidb_schema_cache_size='1GB';
Query OK, 0 rows affected (0.00 sec)
mysql> select @@global.tidb_schema_cache_size;
+---------------------------------+
| @@global.tidb_schema_cache_size |
+---------------------------------+
| 1GB |
+---------------------------------+
1 row in set (0.00 sec)
simlar to tidb_server_memory_limit
mysql> set @@global.tidb_server_memory_limit='1GB';
Query OK, 0 rows affected (0.06 sec)
mysql> select @@global.tidb_server_memory_limit;
+-----------------------------------+
| @@global.tidb_server_memory_limit |
+-----------------------------------+
| 1GB |
+-----------------------------------+
1 row in set (0.00 sec)
Signed-off-by: lilinghai <[email protected]>
Signed-off-by: lilinghai <[email protected]>
|
/test unit-test |
|
@lilinghai: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: lilinghai <[email protected]>
Signed-off-by: lilinghai <[email protected]>
Signed-off-by: lilinghai <[email protected]>
Signed-off-by: lilinghai <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lance6716, wjhuang2016 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #54034
Problem Summary:
What changed and how does it work?
The value range is 0 and [536870912, 9223372036854775807] in bytes. The size format with the units "KB|MB|GB|TB" is supported.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.