Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: do not track membuffer's memory in executor #53985

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

executor: do not track membuffer's memory in executor #53985

wants to merge 1 commit into from
+0 −12

Conversation

ekexium
Copy link
Contributor

@ekexium ekexium commented Jun 13, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #53984

Problem Summary:

What changed and how does it work?

The transaction's memory is already tracked by memdb's tracker

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that transactions' memory usage may be tracked multiple times.

@ti-chi-bot ti-chi-bot bot added release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 13, 2024
@tiprow tiprow
Copy link

tiprow bot commented Jun 13, 2024

Hi @ekexium. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ekexium ekexium requested a review from XuHuaiyu June 13, 2024 05:20
@ekexium ekexium force-pushed the fix-duplicate-txn-mem-tracking branch from be51dc3 to faf34a0 Compare June 13, 2024 06:11
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 13, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.7648%. Comparing base (2ee6d22) to head (faf34a0).
Report is 74 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #53985         +/-   ##
=================================================
- Coverage   72.5183%   55.7648%   -16.7535%     
=================================================
  Files          1508       1628        +120     
  Lines        431874     602535     +170661     
=================================================
+ Hits         313188     336003      +22815     
- Misses        99243     243386     +144143     
- Partials      19443      23146       +3703
Flag Coverage Δ
integration 37.1972% <ø> (?)
unit 71.4323% <ø> (-0.0719%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 50.5825% <ø> (+8.3740%) ⬆️

@ekexium ekexium requested review from cfzjywxk and you06 June 24, 2024 09:12
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-24 11:20:32.975581139 +0000 UTC m=+632159.461069973: ☑️ agreed by cfzjywxk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@you06 you06 Awaiting requested review from you06

Assignees
No one assigned
Labels
approved needs-1-more-lgtm release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transaction's memory usage is tracked multiple times
2 participants
@ekexium @cfzjywxk