Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Client init shouldn't need to be async / project name should be internal #50

Open
2 tasks done
jake-sager opened this issue May 3, 2023 · 1 comment
Open
2 tasks done
Labels
enhancement New feature or request

Comments

@jake-sager
Copy link

Is this your first time submitting a feature request?

  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing functionality

Describe the feature

The client init is async because it needs to resolve the project name. This is a pretty weird pattern -- why can't we just pass in project name like api keys / index names / etc? Seems like a case of an internal implementation detail making the client rather clunky.

Perhaps separately, confusing that the client needs to consider an internal implementation detail like project name (but it's a different project name from the user created one, which is also weird?) is so exposed to client. This adds clunkiness / extra work to the client. Also adds a step to the HTTP call.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@jake-sager jake-sager added the enhancement New feature or request label May 3, 2023
@AndreiIgna
Copy link

I agree with what @jake-sager said, and want to add another point:

This extra http request makes the search experience slower. There are many cases, like edge functions mentioned in other issues, that need to send a response as fast as possible, especially for search.

Having a 3rd config option is a good tradeoff for having simplified code for Pinecone init and faster search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants