feat: Adding SESSION_COOKIE_PARTITIONED #5499
Draft
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure what you mean here. You should follow our contributing guide to set up your development environment. It instructs you to do |
|
Hello, thank you for your response, I went ahead and applied changes without taking a look at the contribution guide, I just went through it and will make the process correctly, my apologies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is related to Add support for partitioned session cookies
fixes #5472
Regarding the commit Adding code to handle SESSION_COOKIE_SECURE I see that in the test_basic.py in line 20 is using
import flask, I believe this is the reason I got this error as it's using the package installed viapip install flaskand not the code contained in /src/flask/I'd like to learn if I'm doing something wrong with this to correct it and modify the PR