Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateRangePicker singleMonthOnly does not support showing "outside" days #4373

Open
nhd2106 opened this issue Oct 16, 2020 · 3 comments · May be fixed by #6862
Open

DateRangePicker singleMonthOnly does not support showing "outside" days #4373

nhd2106 opened this issue Oct 16, 2020 · 3 comments · May be fixed by #6862
Assignees
@evansjohnson
Labels
help wanted P3 Package: datetime Type: bug

Comments

@nhd2106
Copy link

nhd2106 commented Oct 16, 2020 •
edited
Loading

ReactJS

  • Package version(s): "@blueprintjs/datetime": "^3.15.1"
  • Browser and OS versions: 86.0.4240.75 (Official Build) (64-bit), windows 10 2004

Question

in DateRangePicker, DateRangeInput picker Components, I cannot see "outside days" even I set DayPicker props: showOutsideDays to TRUE,
Could you help me figure this out
many thanks for your support
@adidahiya
Copy link
Contributor

@nhd2106 can you please demonstrate your issue with a code sandbox (linked from the issue template)?

@Gatix
Copy link

Gatix commented Feb 23, 2021

Here's a code sandbox of the said issue: https://codesandbox.io/s/blueprint-sandbox-forked-hrpnn?file=/src/DatetimeExample.tsx

@adidahiya adidahiya changed the title DateRangePicker and DateRangeInput DateRangePicker singleMonthOnly does not support showing "outside" days Feb 23, 2021
@adidahiya
Copy link
Contributor

Thanks for the sandbox @Gatix. I've updated the issue title to reflect the problem more clearly. Here's the line of code in question, it just has to be tweaked to not apply this style when singleMonthOnly={true}:

blueprint/packages/datetime/src/_daterangepicker.scss

Line 35 in 5c1cf83

visibility: hidden;

@evansjohnson evansjohnson linked a pull request Jun 24, 2024 that will close this issue
Open
2 tasks
@evansjohnson evansjohnson self-assigned this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evansjohnson evansjohnson

Labels
help wanted P3 Package: datetime Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect showOutsideDays prop for single month date range palantir/blueprint
4 participants
@adidahiya @Gatix @evansjohnson @nhd2106