Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show unstaged modifications to submodules #124

Open
jonathanhanna opened this issue Apr 29, 2021 · 6 comments
Open

Show unstaged modifications to submodules #124

jonathanhanna opened this issue Apr 29, 2021 · 6 comments

Comments

@jonathanhanna
Copy link

When a file in a submodule is modified, running git status in the parent repository will show that the submodule has been modified.
image

GitHub Desktop also shows changes have been made:
image

It would be helpful if Oxygen's Git plugin also showed modifications under Unstaged files.

@AlexJitianu
Copy link
Collaborator

Hello,

I see... When the submodule has unstaged/staged resources we should present that marker file. We currently present it when new commits appear in the submodule.

@kirkilj
Copy link

kirkilj commented May 6, 2022

@AlexJitianu, are you talking about new commits in the local repo or remote repo of a submodule?

We currently present it when new commits appear in the submodule.

@AlexJitianu
Copy link
Collaborator

When a new commit appears in the local repo. We were thinking to decorate the pull button when there are changes in the submodule's remote repo, but we didn't do it yet.

@kirkilj
Copy link

kirkilj commented May 14, 2022

I believe I requested or up voted that feature awhile ago. Our dev group received a Feature request thus week about getting notified when a submodule is ahead on the server. Besides the decoration, could there be a preference to also check submodules and perform a submodule update on the dialog you currently offer to pull changes when the remote is ahead?

@AlexJitianu
Copy link
Collaborator

What does "getting notified when a submodule is ahead on the server" mean? Is this from the administrator's or from the tech writer's perspective? What I mean by that:

  • the admin perspective: there are new commits or new tags in the submodule repo. You want to be notified because you might need to bind the submodule to a newer tag.
  • the tech writer's perspective: an admin has bound the submodule to a newer tag and you want to be notified about that. Right now we have a "Update all submodules after pulling changes from the remote repository" option who will do that, but we miss the notification part. A decorator on the pull button, perhaps.

@kirkilj
Copy link

kirkilj commented May 23, 2022

Hi Alex, we don't have separate roles like that for the most part. Our writers document complex software that manages telecom networks, and most have engineering degrees. If a submodule is associated with a git tag on a specific commit in the target repo, they'd want to know if there were any new tags with commits with a later date compared to the current one.

This was some of the motivation for me mocking up a proposed Branch Manager view and sending it to you guys, which incorporated git tags and submodules as well so all these aspects could appear in the same view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants