Intentional Fallthrough?

[r-barnes]

Bug report

Is this fallthrough from B64_ENCODE_CONDITIONAL into B64_ENCODE intentional?

If so, can we mark it with __attribute__((fallthrough)); to facilitate enabling -Wimplicit-fallthrough?

What operating system and version are you using?

source code question

What version of osquery are you using?

master

What steps did you take to reproduce the issue?

What did you expect to see?

What did you see instead?

[Smjert]

Hello @r-barnes, I would say it is intentional; the conditional_to_base64 function is documented here: https://osquery.readthedocs.io/en/latest/introduction/sql/#encoding-functions, and so it encodes to base64 only if the character is not printable (ASCII).

I think annotating it with fallthrough is sensible, I would use though the standard notation [[fallthrough]], which should be available since we are compiling with C++17 as the standard.