Windows CI broken

[mchitre]

Windows CI is broken as one of the JAR attributes turns out to be null on Windows:

jar {
  manifest {
    attributes 'Build-Owner': System.getenv().USER, 'Build-Timestamp': new Date().format('d-MM-yyyy_HH:mm:ss'), 'Build-Version': "${project.version}/${commit}"
  }
}

perhaps System.getenv().USER?

Temporarily disabled Windows CI to avoid it from canceling Linux CI.

[notthetup]

I've a branch which fixes some of these issues but not all..

https://github.com/org-arl/fjage/tree/windows-github-actions

[notthetup]

OK. I fixed this branch (mostly just rebase) https://github.com/org-arl/fjage/tree/windows-github-actions to make the windows build work on CI.

Most of the other tests seem to be passing but the Java ShellAgent testShell fails when deleting files.

I moved the hardcoded dir to java.io.tmpdir for the test so it could create/delete the file from the appropriate temporary directory based on the platform. And all the other tests pass, except somehow the delete test. Any ideas?

org.arl.fjage.test.BasicTests > testShell STANDARD_ERROR
    1636449167759|INFO|org.arl.fjage.test.BasicTests@1:testShell|testShell
    1636449167761|INFO|org.arl.fjage.Container@35:shutdown|Initiating shutdown...
    1636449167762|INFO|org.arl.fjage.Container@35:shutdown|All agents have shutdown
    2000|INFO|org.arl.fjage.DiscreteEventSimulator@34:run|Simulator shutdown
    1636449167767|INFO|org.arl.fjage.Container@1:init|Initializing agents...
    1636449167768|INFO|org.arl.fjage.shell.ShellAgent@40:init|Agent shell init
    1636449167868|INFO|org.arl.fjage.Container@1:init|Agents ready...
    1636449167868|INFO|org.arl.fjage.Container@1:start|Starting container...
    1636449168468|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|put1 rsp: AGREE
    1636449168469|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|get rsp: INFORM: GetFileRsp
    1636449168469|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|get data len: 14
    1636449168470|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|get data: this is a test
    1636449168473|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|get2 rsp: INFORM: GetFileRsp
    1636449168474|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|get data len: 4
    1636449168474|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|get data: is a
    1636449168475|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|get3 rsp: INFORM: GetFileRsp
    1636449168475|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|get data len: 5
    1636449168475|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|get data:  test
    1636449168476|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|get4 rsp: REFUSE
    1636449168487|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|put2 rsp: AGREE
    1636449168495|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|put3 rsp: AGREE
    1636449168495|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|put3 length 40 : 40
    1636449168497|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|put4 rsp: AGREE
    1636449168504|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|get dir rsp: INFORM: GetFileRsp
    1636449168505|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|DIR: 1/	0	1636448922298
    1636449168505|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|DIR: chocolatey/	0	1635980127229
    1636449168505|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|DIR: fjage-test.txt	14	1636449168496
    1636449168505|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|DIR: hsperfdata_runneradmin/	0	1636449164631
    1636449168506|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|DIR: NuGetScratch/	0	1635980137176
    1636449168507|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|DIR: RazorVSFeedbackLogs/	0	1635980267118
    1636449168507|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|DIR: servicehub/	0	1635980216516
    1636449168508|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|DIR: TFR966E.tmp	416	1635980172871
    1636449168508|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|DIR: v8-compile-cache/	0	1636449141434
    1636449168508|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|DIR: vs.mcj872576055/	0	1635980351943
    1636449168508|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|DIR: VSFaultInfo/	0	1635980276161
    1636449168508|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|DIR: VSFeedbackPerfWatsonData/	0	1635980348213
    1636449168508|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|DIR: VSLogs/	0	1635980312299
    1636449168509|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|DIR: VSTelem/	0	1635980347565
    1636449168509|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|DIR: VSTelem.Out/	0	1635980348213
    1636449168510|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@41:action|del rsp: FAILURE
    1636449168871|INFO|org.arl.fjage.Container@42:shutdown|Initiating shutdown...
    1636449168872|INFO|org.arl.fjage.shell.ShellAgent@40:shutdown|Agent shell shutdown
    1636449168874|INFO|org.arl.fjage.Container@42:shutdown|All agents have shutdown

[mchitre]

Hmm. The FAILURE response without an exception logged seems to suggest that File.delete() returns false. But the file clearly exists, since all other tests pass and we see it in the DIR listing. Might be worth printing filename in ShellAgent, just before deleting and removing the if (rsp != null && rsp.getPerformative() == Performative.AGREE) check in BasicTests.java to see if the file actually got deleted.

[notthetup]

1636604435502|INFO|org.arl.fjage.shell.ShellAgent@38:handlePutFileReq|Deleting file C:\Users\RUNNER~1\AppData\Local\Temp\fjage-test.txt >> false

1636604435503|WARNING|org.arl.fjage.shell.ShellAgent@38:handlePutFileReq|C:\Users\RUNNER~1\AppData\Local\Temp\fjage-test.txt: The process cannot access the file because it is being used by another process.

1636604435509|INFO|org.arl.fjage.test.BasicTests$ShellTestAgent@39:action|del rsp: FAILURE

[notthetup]

Seems like File.delete doesn't give much explanation as to why it failed, but Files.delete() does throw this exception.

1636604435503|WARNING|org.arl.fjage.shell.ShellAgent@38:handlePutFileReq|C:\Users\RUNNER~1\AppData\Local\Temp\fjage-test.txt: The process cannot access the file because it is being used by another process.

[notthetup]

Ah! I know the file is being held open by the isCache! Cleaning it before deleting seems to help!