-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zpool cache not respected by opnsense #7553
Comments
The code you may want to improve is this: Lines 153 to 160 in 0f73da0
Do not confuse _load with _enable vars. We don’t use the RC subsystem that much as it tends to interfere with the boot sequence. |
Adding The behavior of This changes in OpenZFS, used in 13+, the environment variable ZPOOL_IMPORT_PATH is used as the search path: |
Thanks for looking into this. Feel free to provide a PR, but I won't be able to review and commit in the next two weeks. |
(I'd say that ZPOOL_IMPORT_PATH might be the better path forward as I've avoided -c in the past for portability.) |
I'll open a PR to fix this this evening. I can work around this issue for now, so no rush on the review. |
I will propose a change that imports pools from zpool cache at boot (just like vanilla FreeBSD) rather than allowing the implementation of zpool import to dictate what's imported. Pros of using zpool cache
Cons of using zpool cache
|
Important notices
Before you add a new report, we ask you kindly to acknowledge the following:
Describe the bug
zpools other than zroot present in zpool cache (/etc/zfs/zpool.cache or /boot/zfs/zpool.cache) are not imported at boot time in OPNsense 24.1.9.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Upon reboot, the newly created zpool was imported.
Describe alternatives you considered
It is possible to manually import the zpool using zpool import after the reboot, but this doesn't really scale.
I was able to get the pool to import as expected by adding
zfs_enable="YES"
to /etc/rc.conf which allowed /etc/rc.d/zfs to start at boot per expectations. I notice opnsense sets this variable in /usr/local/etc/rc.loader.d/20-zfs, perhaps this variable isn't making it to freebsd's rc.d?Screenshots
If applicable, add screenshots to help explain your problem.
Relevant log files
If applicable, information from log files supporting your claim.
Additional context
Add any other context about the problem here.
Environment
Software version used and hardware type if relevant, e.g.:
OPNsense 24.1.9
The text was updated successfully, but these errors were encountered: