Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue]: Add python bindings for TensorDescriptor #24909

Closed
akuporos opened this issue Jun 7, 2024 · 15 comments · Fixed by #25083
Closed

[Good First Issue]: Add python bindings for TensorDescriptor #24909

akuporos opened this issue Jun 7, 2024 · 15 comments · Fixed by #25083
Assignees
Labels
category: Python API OpenVINO Python bindings good first issue Good for newcomers no_stale Do not mark as stale
Milestone

Comments

@akuporos
Copy link
Contributor

akuporos commented Jun 7, 2024

Context

Needs to add bindings for Python API.

What needs to be done?

Add bindings of methods here.
Please, also add like property (names is good example).
And cover it by documentation (also examples are in the linked file).

Methods:

ov::descriptor::Tensor::get_lower_bound / set
ov::descriptor::Tensor::get_upper_bound / set
ov::descriptor::Tensor::get_value_symbol / set

After that please add tests here and here.
TensorDescriptor may be get via get_tensor method.

Example Pull Requests

No response

Resources

Contact points

@akuporos @jiwaszki @p-wysocki

Ticket

140495

@akuporos akuporos added good first issue Good for newcomers no_stale Do not mark as stale category: Python API OpenVINO Python bindings labels Jun 7, 2024
@amkarn258
Copy link
Contributor

Hi @akuporos ,

Can you please assign this issue to me? I'm new to opensource and would like to help

@mlukasze
Copy link
Contributor

you are very welcome @amkarn258, have fun :)

@amkarn258
Copy link
Contributor

amkarn258 commented Jun 15, 2024

Getting some testing issues. I built using the steps given here and here. Then when I was testing using this documentation, I'm getting this error :

`> from .test_utils_api import compare_functions
E ModuleNotFoundError: No module named 'openvino.test_utils.test_utils_api'

../../../bin/intel64/Release/python/openvino/test_utils/init.py:5: ModuleNotFoundError
============================================================================== short test summary info ==============================================================================
FAILED tests/test_runtime/test_core.py::test_add_extension_template_extension - RuntimeError: Exception from src/inference/src/cpp/core.cpp:158:
FAILED tests/test_utils/test_utils.py::test_compare_functions - ModuleNotFoundError: No module named 'openvino.test_utils.test_utils_api'
==================================================================== 2 failed, 6956 passed, 40 skipped in 16.39s ====================================================================`

I can share my openvino.test_utils.init file if needed.

@amkarn258
Copy link
Contributor

Also, I do not see any errors when building

@Saharshjain78
Copy link

Is this issue currently assigned to someone, because I want to work on this.

@mlukasze
Copy link
Contributor

hey @Saharshjain78
yes, the task is assigned to @amkarn258 for now.

@amkarn258
Copy link
Contributor

@mlukasze is this not compatible with ubuntu 24.04?

@mlukasze
Copy link
Contributor

we are not supporting U24 officially for now, however if problems you are facing might be related with this version of Ubuntu we will be grateful for reporting everything

cc/ @ilya-lavrenov

@ilya-lavrenov
Copy link
Contributor

Problem with importing of test utils, which is not related to python / OS versions
Make sure you have compiled with ENABLE_TESTS=ON

@amkarn258
Copy link
Contributor

@ilya-lavrenov it says there is no such supported option. Also I couldn't see this option anywhere in documentation page here

kingslayer@kingslayer-IdeaPad-Gaming-3-15ARH05:~/Desktop/clone_apps2/openvino/build$ cmake -DCMAKE_BUILD_TYPE=Release -ENABLE_TESTS=ON ..
CMake Error: Unknown argument -ENABLE_TESTS=ON
CMake Error: Run 'cmake --help' for all supported options.

@ilya-lavrenov
Copy link
Contributor

you should add D, because all options in cmake are passed -Doption_name=value

@akuporos
Copy link
Contributor Author

akuporos commented Jun 17, 2024

Hello @amkarn258,

I believe you don't need to run test_utils folder for this task.
It'll be enough for you to run them like pytest tests/test_runtime/

@amkarn258
Copy link
Contributor

amkarn258 commented Jun 17, 2024

Hi, Have linked a PR for this issue.

@mlukasze mlukasze linked a pull request Jun 18, 2024 that will close this issue
github-merge-queue bot pushed a commit that referenced this issue Jun 18, 2024
### Details:
Bindings of methods get_lower_value/set, get_upper_value/set and
get_value_symbol/set added for tensor descriptor along with their
respective tests.

### Tickets:
 - *140495*

Closes Issue
[#24909](#24909)

---------

Co-authored-by: Przemyslaw Wysocki <[email protected]>
Co-authored-by: Anastasia Kuporosova <[email protected]>
@akuporos
Copy link
Contributor Author

@amkarn258 once again, thank you for your contribution!

If you are interested in enhancing OpenVINO Python API, please, consider these tickets: #21969 and #18347

@amkarn258
Copy link
Contributor

Welcome @akuporos,

And sure, happy to help. I saw that #21969 is currently assigned to @Saharshjain78 , I can take the #18347.

@mlukasze mlukasze added this to the 2024.3 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Python API OpenVINO Python bindings good first issue Good for newcomers no_stale Do not mark as stale
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

5 participants