Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red pjama 3b instruct #352

Closed
wants to merge 7 commits into from
Closed

Conversation

akiseakusa
Copy link
Contributor

This should close #276 , I have updated the model list , and added tests taking reference from issue description at #259 , @p-wysocki @ilya-lavrenov @pavel-esir in the readme I have added Red pjama 3b separately along with that huggingface comparison has also added. please let me know if anything else can be done.

@ilya-lavrenov
Copy link
Contributor

Please, resolve merge conflicts.

@ilya-lavrenov ilya-lavrenov self-assigned this Apr 15, 2024
@ilya-lavrenov
Copy link
Contributor

Please, resolve merge conflicts

@akiseakusa akiseakusa closed this Apr 28, 2024
@akiseakusa akiseakusa deleted the red-pjama branch April 28, 2024 15:44
@akiseakusa akiseakusa restored the red-pjama branch April 28, 2024 16:50
@akiseakusa akiseakusa reopened this Apr 28, 2024
@akiseakusa
Copy link
Contributor Author

@ilya-lavrenov Sorry for the delay,I have resolved the conflict. please check.

@@ -12,6 +12,87 @@ concurrency:
cancel-in-progress: true

jobs:
cpp-beam_search_causal_lm-red-pajama-3b-instruct:
runs-on: ubuntu-20.04-16-cores
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
runs-on: ubuntu-20.04-16-cores
runs-on: ubuntu-20.04

Can you try the smaller runner?

run: |
source ./ov/setupvars.sh
convert_tokenizer ./RedPajama-INCITE-Instruct-3B-v1/pytorch/dldt/FP16/ --output ./RedPajama-INCITE-Instruct-3B-v1/pytorch/dldt/FP16/ --with-detokenizer --trust-remote-code
timeout 50s ./build/beam_search_causal_lm .RedPajama-INCITE-Instruct-3B-v1/pytorch/dldt/FP16/ 69 > ./pred.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
timeout 50s ./build/beam_search_causal_lm .RedPajama-INCITE-Instruct-3B-v1/pytorch/dldt/FP16/ 69 > ./pred.txt
timeout 50s ./build/beam_search_causal_lm ./RedPajama-INCITE-Instruct-3B-v1/pytorch/dldt/FP16/ 69 > ./pred.txt

"
echo 69 passed

cpp-beam_search_causal_lm-Mistral-7B:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it won't ever pass, please remove it. #371

@@ -396,46 +475,3 @@ jobs:
predictions = predictions[:idx] + predictions[idx + len(ref):]
"
echo Phi-1_5 passed

cpp-greedy_causal_lm-redpajama-3b-chat:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you remove it? Can you merge it with your test implementation

@@ -148,7 +148,6 @@ To enable Unicode characters for Windows cmd open `Region` settings from `Contro
2. https://huggingface.co/microsoft/phi-1_5
9. [notus-7b-v1](https://huggingface.co/argilla/notus-7b-v1)
10. [zephyr-7b-beta](https://huggingface.co/HuggingFaceH4/zephyr-7b-beta)
11. [redpajama-3b-chat](https://huggingface.co/ikala/redpajama-3b-chat)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you remove redpajama-3b-chat?

@andrei-kochin
Copy link
Collaborator

@akiseakusa could you please apply the comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Verify red-pajama-3b-instruct with GenAI text_generation
4 participants