[Good First Issue] [NNCF] Make NNCF common utils code pass mypy checks

[vshampor]

This is exactly like #2495 (see the description and tasks there), but the target code path for this one is nncf/common/utils instead of nncf/common/graph.

[tvilight4]

.take

[github-actions]

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

[ishan121028]

.take

[github-actions]

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. Please communicate with the assigned contributor to confirm the status of the issue.

[tvilight4]

I am currently working on the issue. Facing a few problems but trying to solve them..will give the updates in a few days

[p-wysocki]

Hello @tvilight4, is there anything we can help you with?

[tvilight4]

@p-wysocki I am new to type hinting and so figuring out the solution is taking time, Do the location of the function calls matter in the codebase? If yes it would be great if you could tell me where the function is_tensorflow_model(model: TModel) being called...as
nncf/common/utils/backend.py:73: error: Cannot find implementation or library stub for module named "tensorflow"
is the first mypy error which i am trying to solve.

[p-wysocki]

Hello @tvilight4, usually the best way to fix mypy errors is to google them - quite often you even can find copy and paste fixes for the errors. It seems that particular one could be changed by modifying the import line: https://stackoverflow.com/questions/68695851/mypy-cannot-find-implementation-or-library-stub-for-module

[p-wysocki]

Hello @tvilight4, do you need any help?

[tvilight4]

@p-wysocki I a working on it but will need time till 20 march due to my university exams going on.

[p-wysocki]

Hello @tvilight4, are you still working on this?

[tvilight4]

Sorry @p-wysocki I have not been able to work on this issue due to other urgent commitments.
I would opt to unassign myself for now so that someone else can take it up. If I get some solution, I will inform you. I am extremely sorry for the delay and inconvenience caused.

[p-wysocki]

Don't worry, there are no deadlines in Good First Issues, we're just looking for abandoned tasks for other people to pick up. :) For now I'm reopening the task, but feel free to pick up something else or even this one from our board as soon as you have some time!

cc @vshampor could you please reopen the task?

[anzr299]

I would like to take this issue when it opens @p-wysocki

[anzr299]

.take

[github-actions]

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. Please communicate with the assigned contributor to confirm the status of the issue.

[anzr299]

.take

[github-actions]

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

[anzr299]

@alexsu52 I am trying to define the _registry_dict dictionary in the Registry class. I have decided to go ahead with a general object type for both the keys and values. I am facing some errors in nncf\common\graph\patterns\manager.py wherein the expected type is Dict[HWFusedPatternNames, Callable[[], GraphPattern] for the registry dict. Casting it to the type expected from the general object typing works. I was wondering if casting would be accepted as a solution?

[alexsu52]

@anzr299, casting is applicable solution for this case. Let's discuss this in more detail in PR.

[anzr299]

Sure, just to clarify, I think the issue referred to by @MaximProshin is #2637.

[p-wysocki]

Hello @anzr299, are you still working on that issue? Do you need any help?

[anzr299]

Hi @p-wysocki, I was busy for the past few days. I will continue working on this issue now.