Latest version is not working with sail enabled

[Alph44rchitect]

Describe the bug
The latest extension version is not working with Laravel Sail setting enabled. It seems to be ignored.

To Reproduce
Steps to reproduce the behavior:

1. Install Laravel sail
2. Install latest version of the extension
3. Set enableDebugLogs: true
4. Set runInLaravelSail: true
5. Run format command
6. Watch the output log and see that is still using the non sail path

Expected behavior
Using the sail path to run pint.

Environment:

• Operating system: Ubuntu 22.04 via Windows with WSL2
• IDE / version: VSCode / latest
• Extension version: 1.1.4
• Extension's config: enableDebugLogs: true, runInLaravelSail: true

Additional context
The version 0.7.3 works as expected.

[d8vjork]

Thanks for raising the issue!

Will take a look at this

[benjamindonze]

+1 on this issue

[d8vjork]

Sorry to say but this feature cannot be viable, as VSCode doesn't provide same Bash/Zsh/shell context with it so doesn't know where Docker is or any other binary, for global Pint this uses a predefined path setting, but Sail needs Docker therefore need to be on the PATH, the one we can't have access to from an child process from the VSCode one (unless some special things applied to this one).

Anyway will continue on the research of this and add help wanted

[GringoDotDev]

@d8vjork have you considered something like this?

docker-compose exec -T laravel.test ./vendor/bin/pint

This executes the command inside the default app container that comes with Sail and logs the output to terminal. Should be executable from the shell context of VSCode and its extensions (works fine for me locally anyway.)

[d8vjork]

@jseitel Problem with that still the same, need to find out where is that docker-compose (or in case of newer versions, docker compose), could be specified on an extension setting tho

[Alph44rchitect]

@d8vjork I haven't looked into the details but it was working as expected with v0.7.3 and still is. What changed?

[d8vjork]

@d8vjork I haven't looked into the details but it was working as expected with v0.7.3 and still is? What changed?

You are actually right... after checking 0.7.x I discovered that I was actually wrapping the execution into a VSCode Task, will try if I could achieve the same on this new refactor I did on v1

Note to myself: Use ShellExecution from VSCode API to wrap the command

[ricardosoares09]

Laravel pint vscode, still isn't working with docker/sail, is there any development on this ? Is there any workaround?

[AprilOneDay]

Laravel pint vscode, still isn't working with docker/sail, is there any development on this ? Is there any workaround?

use 0.7.3