Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Option to change colour theme from system default #4029

Open
micmalti opened this issue Jun 4, 2024 · 0 comments
Open

Android: Option to change colour theme from system default #4029

micmalti opened this issue Jun 4, 2024 · 0 comments
Assignees
Labels

Comments

@micmalti
Copy link

micmalti commented Jun 4, 2024

First of all, thank you for open-sourcing this project. Having the ability to self-host down the road was one of the key reasons why I switched over to Omnivore from Pocket.

In the Android version, the colour theme automatically follows the system default, with no option of changing it except from within the reading view, though any change is limited to this view only.

Understandably, there are other issues which require more attention than expanding the app theming options, so I think it would be enough for the time being to grant users the option to choose between the two currently available themes. A potential way of doing this is by replacing isSystemInDarkTheme() with a DarkThemePref() mapped to an 'Enable dark mode' checkbox in the profile settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants