-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResolveMojo
should not be part of assemble
cycle
#3199
Comments
ResolveMojo
should not be part of assemble
cycleResolveMojo
and MarkMojo
should not be part of assemble
cycle
@maxonfjvipon the issue body is empty, please provide more details for this problem. |
ResolveMojo
and MarkMojo
should not be part of assemble
cycleResolveMojo
should not be part of assemble
cycle
@maxonfjvipon why do we need to scan EO-SOURCES by the way? Shouldn't we get a list of all necessary objects from the objects already downloaded? I mean, from their sources. If my project depends on the Maybe the problem is that |
@yegor256
Here |
@maxonfjvipon maybe let's make it mandatory for every object to mention all dependencies that it has, right in the |
@yegor256 sounds good. Could you please clarify a bit how we should restrict usages of objects inside atoms? |
@yegor256 maybe we can also introduce some new annotation for such cases to make it different from |
@maxonfjvipon actually, Then, inside Java implementation of atoms we may simply let programmers either 1) use |
@yegor256 first option |
@maxonfjvipon when we compile
becomes in Java: class EObar {
public EObar() {
this.add("foo", new AtAlso(new AtOnce(...), ["xyz"]);
}
} Inside this new How will |
@yegor256 until we figure out how to implement this checking we can:
|
@maxonfjvipon good plan |
There's a strange reason why
ResolveMojo
andMarkMojo
are inassemble
cycle.ResolveMojo
downloads.jar
packages fromMaven Central
. Package contains.class
files and directoryEO-SOURCES
with.eo
source files.MarkMojo
scansEO-SOURCES
directory and extendsforeign-tojos
with visible EO objects.We actually need this
MarkMojo
insideassembly
cycle because of atoms that may create EO objects that are not visible in EO sources.So what we need:
ResolveMojo
out ofassembly
cycle so it downloads and unpack alljars
after assembling only once.eo-runtime
-> download all sources foreo-runtime
,eo-collections
-> download all sources foreo-collections
This mechanism should be placed instead of
ResolveMojo
inassemble
cycle@yegor256 WDYT?
The text was updated successfully, but these errors were encountered: