Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No panics in nucliadb_texts #985

Open
hermeGarcia opened this issue Jun 13, 2023 · 0 comments
Open

No panics in nucliadb_texts #985

hermeGarcia opened this issue Jun 13, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@hermeGarcia
Copy link
Contributor

Problem
nucliadb_texts is Tantivy index used by Nuclia to enable searching capabilities in the text of a resource. Right now in nucliadb_texts::reader and nucliadb_texts::writer panic at several of their operations by unwrapping a result or an optional. This behaviour must change and partial index operations should return a result specifying what went wrong instead of panicking.

Describe the solution you'd like
Use nucliadb_core::NodeResult to avoid panicking in nucliadb_texts.

Additional context
nucliadb_core::NodeResult is a anyhow::Result.
@hermeGarcia hermeGarcia added the enhancement New feature or request label Jun 13, 2023
@jotare jotare added the good first issue Good for newcomers label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jotare @hermeGarcia