Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for vim.lsp #47

Open
noib3 opened this issue Jul 29, 2022 · 7 comments
Open

Support for vim.lsp #47

noib3 opened this issue Jul 29, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@noib3
Copy link
Owner

noib3 commented Jul 29, 2022

No description provided.

@noib3 noib3 added the enhancement New feature or request label Jul 29, 2022
@willothy
Copy link
Contributor

Seems like these would require bindings directly to lua by fetching globals, since a lot of the LSP/Diagnostics stuff is implemented in Lua. Would you be open to someone contributing that? That's the approach I was taking with nvim-utils, but honestly I'd rather contribute those features to oxi and archive utils as it's not getting much use and oxi provides a better (and faster) API.

@noib3
Copy link
Owner Author

noib3 commented Jul 13, 2023

Seems like these would require bindings directly to lua by fetching globals, since a lot of the LSP/Diagnostics stuff is implemented in Lua.

Yes, that'd be the approach. This is a very rough sketch of such a binding that I wrote for vim.diagnostic.enable.

Would you be open to someone contributing that?

Yes, although I should mention that I don't really have the time to focus on oxi right now (and probably won't for a few months). What this means practically is that you might have to wait a few days to receive feedback on the relative PRs.

@willothy
Copy link
Contributor

No worries! I don't actively need nvim LSP features in Rust so there's no rush, just think it would be nice to have and would be happy to contribute :)

@noib3
Copy link
Owner Author

noib3 commented Jul 13, 2023

I should also mention that I was planning to rewrite Neovim's vim.lsp + nvim-lspconfig + lspsaga.nvim + any-lsp-related-stuff-that-should-be-builtin-instead-of-being-relegated-to-a-3rd-party-plugin in Rust as part of a new project, hopefully before EOY.

However, this is not to say that I wouldn't merge the Rust bindings to vim.lsp into oxi.

@willothy
Copy link
Contributor

Cool! Would be nice to have those implemented in Rust.

@poljar
Copy link

poljar commented May 16, 2024

I should also mention that I was planning to rewrite Neovim's vim.lsp + nvim-lspconfig + lspsaga.nvim + any-lsp-related-stuff-that-should-be-builtin-instead-of-being-relegated-to-a-3rd-party-plugin in Rust as part of a new project, hopefully before EOY.

Is there any more info about this effort now? Any repo we can follow or a dedicated issue?

@noib3
Copy link
Owner Author

noib3 commented May 17, 2024

Is there any more info about this effort now?

Not at the moment. I still intend to write that code but I'm currently focusing on another project. I'll post here when I have an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants