Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nghttpx: log the obfuscated value of forwarded-for #1574

Open
jktjkt opened this issue Mar 25, 2021 · 1 comment
Open

nghttpx: log the obfuscated value of forwarded-for #1574

jktjkt opened this issue Mar 25, 2021 · 1 comment
Labels

Comments

@jktjkt
Copy link
Contributor

jktjkt commented Mar 25, 2021

My app uses the nghttp2_asio library, and as it only speaks HTTP/2, it runs behind the nghttpx reverse proxy. As a result of that, all client connections effectively arrive via the same host+port combination to my app. I'm running nghttpx with the --add-forwarded=for flag so that my app can at least distinguish these requests from each other. However, I have no way to correlate the incoming request handled by nghttpx with what my application sees.

Can you please extend the available parameters in the access log formater within nghttpx so that the value that's used for the --forwarded-for=obfuscated is visible in nghttpx' access logs?

Note that using --forwarded-for=ip is not enough because the client port is not included. Even if it was included, that would still not be enough for me because the client connection can use HTTP/2 as well, and if that's the case, I cannot discriminate two requests which have arrived over the same TCP socket. The obfuscated value looks better in this regard.

Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant