add JavaScriptCodec to serialize JavaScript data structure #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/JavaScriptCodec.ts
Outdated
| case "undefined": { | ||
| return undefined; | ||
| } | ||
| case "Map": { |
There was a problem hiding this comment.
I would move strings to Enum
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=========================================
- Coverage 96.9% 96.81% -0.1%
=========================================
Files 15 16 +1
Lines 905 942 +37
Branches 183 194 +11
=========================================
+ Hits 877 912 +35
- Misses 28 30 +2
Continue to review full report at Codecov.
|
|
@sergeyzenchenko what do you think of it? |
|
Will retry this feature later based on https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental feature to serialize and deserialize JavaScript data structure, just like as https://github.com/yahoo/serialize-javascript
I'm investigating that it really improves performance when
serialize-javascriptis replaced to msgpack, so it is marked as DO NOT MERGE for now.Resolve #58
See also