Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ECN on a path dropping all marked packets #1925

Open
mxinden opened this issue Jun 17, 2024 · 0 comments
Open

Test ECN on a path dropping all marked packets #1925

mxinden opened this issue Jun 17, 2024 · 0 comments

Comments

@mxinden
Copy link
Collaborator

mxinden commented Jun 17, 2024

neqo-transport tests whether a path is ECN capable by marking the first 10 packets:

/// The number of packets to use for testing a path for ECN capability.
pub const ECN_TEST_COUNT: usize = 10;

On a path that drops all ECN marked packets, this could delay connection establishment significantly.

We should test whether this is the case.

Especially relevant, since https://phabricator.services.mozilla.com/D212959 would enable ECN on Firefox.


Related discussion on Slack quicdev.

@marten-seemann:

quic-go only starts ECN validation in 1-RTT. I see little value in the additional complexity of having to deal with correctly accounting for packets that never get acknowledged due to the packet number space being discarded beforehand in my ECN validation logic. Also, it makes the code 100% resilient against ECN blackholes, which is one less thing to worry about when debugging connection failures.

See also quic-go implementation: https://github.com/quic-go/quic-go/blob/master/internal/ackhandler/ecn.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant