Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: Update glob from 8.1.0 which is no longer supported #5148

Open
2 of 3 tasks
einsteinsfool opened this issue May 28, 2024 · 1 comment
Open
2 of 3 tasks
Labels
semver-major implementation requires increase of "major" version number; "breaking changes" status: in discussion Let's talk about it! type: feature enhancement proposal

Comments

@einsteinsfool
Copy link

Feature Request Checklist

Overview

mocha uses [email protected] which is not supported and also depends on inflight which is also not supported (any version).

$ mkdir mochatest
$ cd mochatest
$ npm install mocha
npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
...

I do realise it's been reported in #4988 but I'm not reporting it as security vulnerability but feature request.
It would be nice not to have these warnings. Especially that a lot of packages depend on mocha (like appium from which I came).

Suggested Solution

Updating glob dependency to v9.0.0 or maybe even v10.4.1.

Alternatives

Leave glob v8.1.0 which is no longer supported and ignore warnings.

Additional Info

https://www.npmjs.com/package/inflight
https://www.npmjs.com/package/glob/v/8.1.0

@einsteinsfool einsteinsfool added status: in triage a maintainer should (re-)triage (review) this issue type: feature enhancement proposal labels May 28, 2024
@einsteinsfool einsteinsfool changed the title 馃殌 Feature: <short description of the feature> 馃殌 Feature: Update glob from 8.1.0 which is no longer supported May 28, 2024
@JoshuaKGoldberg
Copy link
Member

Agreed, this would be great. There's no reason to keep glob -or any other dependency- on an outdated major version - especially one that's no deprecated!

#5114 tracks allowing ^ (minor) version matching on packages. That's a semver-minor for us.

I suspect (but am not wholly convinced) for major version bumps we'll want to play it safe and wait until the next major version of Mocha. cc @mochajs/maintenance-crew: we'd previously talked about how we wanted to get to a new major version, but are also hesitant to make new majors given how entrenched the current v10 major version of Mocha is? For reference, we took that strategy in typescript-eslint recently: typescript-eslint@v7's breaking changes were around major versions, while typescript-eslint@v8's breaking chnages are more substantial.

Marking as semver-major and in discussion just in case for now. We'll likely end up filing issues for other dependencies that are on out-of-date majors. The PRs linked in #5114 mention those.

@JoshuaKGoldberg JoshuaKGoldberg added semver-major implementation requires increase of "major" version number; "breaking changes" status: in discussion Let's talk about it! and removed status: in triage a maintainer should (re-)triage (review) this issue labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-major implementation requires increase of "major" version number; "breaking changes" status: in discussion Let's talk about it! type: feature enhancement proposal
Projects
None yet
Development

No branches or pull requests

2 participants