Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "hairpin mode" by-default / more often #47953

Open
robmry opened this issue Jun 11, 2024 · 0 comments
Open

Use "hairpin mode" by-default / more often #47953

robmry opened this issue Jun 11, 2024 · 0 comments
Labels
area/networking/d/bridge area/networking kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. status/0-triage

Comments

@robmry
Copy link
Contributor

robmry commented Jun 11, 2024

Description

From @akerouanton's review comment #47871 (comment) ...

Maybe we can now make 'hairpin mode' the default, or at least use it more often?

  • It was initially introduced in moby/libnetwork@acfac0b
  • Then, libnet devs realized the netlink message used was too new for some kernels supported at that time, as can be seen in this comment: Use sysfs to set hairpin mode libnetwork#412 (comment)
  • netlink uses the const IFLA_BRPORT_MODE, which was introduced by this commit torvalds/linux@c75ea26, which was first released in v3.8.
  • RHEL 8.10 uses 4.18 -- the oldest kernel we've to support. So we should be good by now.
  • But we'd need to double-check if this would introduce new issues, etc...
@robmry robmry added status/0-triage kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. area/networking area/networking/d/bridge labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking/d/bridge area/networking kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. status/0-triage
Projects
None yet
Development

No branches or pull requests

1 participant