Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request/Help: H265 #20

Open
ksmuthucv opened this issue Jun 19, 2023 · 8 comments
Open

Request/Help: H265 #20

ksmuthucv opened this issue Jun 19, 2023 · 8 comments

Comments

@ksmuthucv
Copy link

ksmuthucv commented Jun 19, 2023

Hello @mmozeiko,
The recorded file using h265 (Main_420_8) codec has noise while using the latest version and the earlier version (prior to convert buffer) works as expected. PFA of mock-ups for the same. Can you please advice how to address it?

earlier/working version:
H265Works

not working:
H265Noise

Thanks,
Muthu

@mmozeiko
Copy link
Owner

You mean it worked before and is not working afterwards? Which commit did it work with?
Does it work if you disable GPU encoder?

@ksmuthucv
Copy link
Author

Hello @mmozeiko,
Thank you very much for your time and help, it is really appreciated.

It works fine till commit #f1050973884. https://github.com/mmozeiko/wcap/tree/f105973884e70fda99c8d1e0864d9cf60213e47b

Disabling gpu encoding fails with below error.
no-gpu

Thanks,
Muthu

@mmozeiko
Copy link
Owner

mmozeiko commented Jun 20, 2023

Hmm, I see. Two more questions:

  1. what GPU do you have?
  2. does latest versions work fine when recording with codec set to H264? What about HEVC 10-bit?

Do you have VS installed? If yes, can you run latest source built in debug mode and check debugger output window for any error messages? To build exe in debug mode, run build.cmd debug

@ksmuthucv
Copy link
Author

ksmuthucv commented Jun 20, 2023

  1. I have two gpus, Intel(R) HD Graphics 630 (igpu) and Radeon RX Vega M GH Graphics (xgpu). Commit #f1050973884 works fine with amd gpu.
  2. Yes, h264 works fine in latest code. HEVC 10-bit runs into "Cannot configure video encoder input!" error. please find the details below. H264 is highlighted in green and H265 in red. Also, ran the code in debug mode and it didn't throw any error or fail at a code location.

details

please find the logs of output windows for your reference.
h265-latest.txt
h265-f1050973884 .txt

Thanks,
Muthu

@ksmuthucv
Copy link
Author

ksmuthucv commented Jun 21, 2023

Hello @mmozeiko,
Commenting out the below line from the latest code, seems to have fixed the noise problem of h265.
HR(IMFMediaType_SetUINT64(Type, &MF_MT_FRAME_RATE, MFT64(Config->FramerateNum, Config->FramerateDen))); (wcap_encoder.c, 337).

Thanks,
Muthu

@ksmuthucv ksmuthucv reopened this Dec 29, 2023
@ksmuthucv
Copy link
Author

Hello @mmozeiko,
This issue has re-surfaced again. This happens (latest codebase) with Radeon RX Vega M GH Graphics (xgpu, amd) and the integrated gpu works fine. Can you please advise me what could i look into?

image
amd-gpu-mftrace-vs2022.txt

Thanks,
Muthu

@ksmuthucv
Copy link
Author

Hello @mmozeiko,
I have raised the below issue at AMF and there are few recommendations provided by them as well.
GPUOpen-LibrariesAndSDKs/AMF#434

Thanks,
Muthu

@mmozeiko
Copy link
Owner

mmozeiko commented Jan 3, 2024

Sorry, I'm currently traveling. I'll look into this in couple of weeks when I'm back from vacation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants