Ensure subprocess is terminated in serve_wheel

[harupy]

Summary

To ensure the subprocess running the server is terminated, try-finally should be used.

diff --git a/conftest.py b/conftest.py
index 79987335d..6db5bde9a 100644
--- a/conftest.py
+++ b/conftest.py
@@ -364,10 +364,12 @@ def serve_wheel(request, tmp_path_factory):
         ],
         cwd=root,
     ) as prc:
-        url = f"http://localhost:{port}"
-        if existing_url := os.environ.get("PIP_EXTRA_INDEX_URL"):
-            url = f"{existing_url} {url}"
-        os.environ["PIP_EXTRA_INDEX_URL"] = url
-
-        yield
-        prc.terminate()
+        try:
+            url = f"http://localhost:{port}"
+            if existing_url := os.environ.get("PIP_EXTRA_INDEX_URL"):
+                url = f"{existing_url} {url}"
+            os.environ["PIP_EXTRA_INDEX_URL"] = url
+
+            yield
+        finally:
+            prc.terminate()

Notes

• Make sure to open a PR from a non-master branch.

• Sign off the commit using the -s flag when making a commit:

  git commit -s -m "..."
           # ^^ make sure to use this

• Include #{issue_number} (e.g. #123) in the PR description when opening a PR.

[dominik-pichler]

Hello @harupy, I am looking for my first contribution to MLFlow. Can I work on this issue ?

[harupy]

@dominik-pichler absolutely！

[dominik-pichler]

@harupy Great! can you assign it to me?

[harupy]

@dominik-pichler assigned！