Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure KeyBinding Doesn't Work #218187

Closed
sunliangqin opened this issue Jun 25, 2024 · 5 comments · Fixed by #218372
Closed

Configure KeyBinding Doesn't Work #218187

sunliangqin opened this issue Jun 25, 2024 · 5 comments · Fixed by #218372
Assignees
@benibenj
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders scm General SCM compound issues verified Verification succeeded
Milestone
June 2024

Comments

@sunliangqin
Copy link

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.90.2
  • OS Version: Windows 23H2

Steps to Reproduce:

  1. Make sure you have multiple repos
  2. Right click on the commit id/branch of one repro, then select "Configure Keybinding"
  3. Couldn't find the command

image
@lszomoru
Copy link
Member

@benibenj, as each of these commands is distinct, what would be the right approach to enable this functionality?

@lszomoru lszomoru added under-discussion Issue is under discussion for relevance, priority, approach scm General SCM compound issues labels Jun 26, 2024
@benibenj
Copy link
Contributor

benibenj commented Jun 26, 2024 •
edited
Loading

We are unable to support the Configure Keybinding action for status bar actions. Let me disable it.

@benibenj benibenj mentioned this issue Jun 26, 2024
Merged
@benibenj benibenj added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Jun 26, 2024
@benibenj benibenj added this to the June 2024 milestone Jun 26, 2024
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 26, 2024
@TylerLeonhardt
Copy link
Member

Looks disabled now

Image

@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Jun 26, 2024
@lszomoru
Copy link
Member

@benibenj, I think we should completely remove the action as that will never work as far as I understood.

@benibenj
Copy link
Contributor

I think it's fine to align with the hide action and disable the action when it's not supported. Each action in that toolbar has the hide and key binding action, so I think it makes more sense to disable these actions when they are not supported compared to just not showing them for some actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benibenj benibenj

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders scm General SCM compound issues verified Verification succeeded
Projects
None yet
Milestone
June 2024
5 participants
@sunliangqin @TylerLeonhardt @lszomoru @benibenj @VSCodeTriageBot