Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not show focus border of activity bar on mouse click #217834

Closed
hecticme opened this issue Jun 25, 2024 · 0 comments · Fixed by #217837
Closed

Should not show focus border of activity bar on mouse click #217834

hecticme opened this issue Jun 25, 2024 · 0 comments · Fixed by #217837
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@hecticme
Copy link
Contributor

hecticme commented Jun 25, 2024

When using a mouse to click on the icons of the activity bar, an unwanted focus border will briefly appear.

Does this issue occur when all extensions are disabled?

  • Yes

System Info

  • VS Code Version: v1.90.2
  • OS Version: Linux 6.9 Fedora Linux 40 (Workstation Edition)

Steps to Reproduce

  1. This will be easier to notice if you make "activityBar.activeBorder" transparent, so please do it first. Otherwise, you can make your "focusBorder" color different from "activityBar.activeBorder" to observe the issue.
  2. Use your mouse to click on the Explorer icon in activity bar, a border will appear briefly.

I have attached a screencast. Unfortunately I couldn't capture my mouse, but you can see that in the video I was clicking on the explorer icon the whole time. A border on the left of explorer icon appears on every click.

Screencast.from.2024-06-25.15-11-54.mp4

Further comments

This only happens with the explorer icon at first, other tabs' icon does not have this kind of UI flickering. However, if you focus on the activity bar and navigate through all the icons with keyboard's arrows, the problem will be reproducable with all icons.

Judging by the fact that this only happens with explorer icon initially, I don't think it's intentional. I also don't like the flickering :/

@bpasero bpasero assigned sbatten and benibenj and unassigned bpasero Jun 25, 2024
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jun 26, 2024
@VSCodeTriageBot VSCodeTriageBot added this to the June 2024 milestone Jun 26, 2024
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants