Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intellisense doesn't include the completion I want #211996

Closed
amunger opened this issue May 3, 2024 · 7 comments 路 Fixed by #215581
Closed

intellisense doesn't include the completion I want #211996

amunger opened this issue May 3, 2024 · 7 comments 路 Fixed by #215581
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders papercut 馃└ A particularly annoying issue impacting someone on the team terminal-suggest verified Verification succeeded
Milestone
June 2024

Comments

@amunger
Copy link
Contributor

amunger commented May 3, 2024

Steps to Reproduce:

  1. type git checkout -- . and press enter
    馃悰 intellisense completion was added for the argument instead of running the command

I have a pretty strong muscle memory to run that command, so now I need to remember to press escape before pressing enter

image
@amunger amunger added the papercut 馃└ A particularly annoying issue impacting someone on the team label May 8, 2024
@amunger
Copy link
Contributor Author

amunger commented May 8, 2024

this is bad enough that I've turned the feature off, I can't even use git status

@Tyriar
Copy link
Member

Tyriar commented May 30, 2024

I also hit these issues particularly with git:

image
image

@Tyriar Tyriar added this to the June 2024 milestone May 30, 2024
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-suggest labels May 30, 2024
@amunger
Copy link
Contributor Author

amunger commented May 30, 2024

one change that would make this much less painful: ctrl+z should undo the auto-complete change as a single action (as is the case with the text editor).
I press enter really quickly, after typing what I want, and if auto-complete provides something I didn't want, ctrl+z will undo one character at a time.

@Tyriar
Copy link
Member

Tyriar commented May 30, 2024 •
edited
Loading

Well powershell does support ctrl+z itself. We may be able to undo everything, or nearly everything by using bracketed paste mode, since you can paste something and undo it fine. #213937

@Tyriar Tyriar mentioned this issue May 30, 2024
Closed
@Tyriar
Copy link
Member

Tyriar commented Jun 14, 2024

Just tried with Posh-Git and while the commands (checkout) and aliases (co in mine) work, it still doesn't suggest . after checkout:

Screenshot 2024-06-14 at 9 56 45鈥疉M

@Tyriar
Copy link
Member

Tyriar commented Jun 14, 2024

(TabExpansion2 -inputScript "git co " -cursorColumn 7).CompletionMatches doesn't show files/folders so we couldn't use that. Maybe using the current completion call, but also providing ., .., etc. when there are only ProviderContainer and ProviderItem entries?

~/dev/Tyriar/xterm.js [tyriar/vscode_213174 鈮> (TabExpansion2 -inputScript "git co ." -cursorColumn 8).CompletionMatches

CompletionText           ListItemText                  ResultType ToolTip
--------------           ------------                  ---------- -------
./.devcontainer          .devcontainer          ProviderContainer /Users/tyriar/dev/Tyriar/xterm.js/.devcontainer
./.editorconfig          .editorconfig               ProviderItem /Users/tyriar/dev/Tyriar/xterm.js/.editorconfig
./.eslintrc.json         .eslintrc.json              ProviderItem /Users/tyriar/dev/Tyriar/xterm.js/.eslintrc.json
./.eslintrc.json.typings .eslintrc.json.typings      ProviderItem /Users/tyriar/dev/Tyriar/xterm.js/.eslintrc.json.typings
./.git                   .git                   ProviderContainer /Users/tyriar/dev/Tyriar/xterm.js/.git
./.gitattributes         .gitattributes              ProviderItem /Users/tyriar/dev/Tyriar/xterm.js/.gitattributes
./.github                .github                ProviderContainer /Users/tyriar/dev/Tyriar/xterm.js/.github
./.gitignore             .gitignore                  ProviderItem /Users/tyriar/dev/Tyriar/xterm.js/.gitignore
./.gitmodules            .gitmodules                 ProviderItem /Users/tyriar/dev/Tyriar/xterm.js/.gitmodules
./.mailmap               .mailmap                    ProviderItem /Users/tyriar/dev/Tyriar/xterm.js/.mailmap
./.mocha.env             .mocha.env                  ProviderItem /Users/tyriar/dev/Tyriar/xterm.js/.mocha.env
./.mocharc.yml           .mocharc.yml                ProviderItem /Users/tyriar/dev/Tyriar/xterm.js/.mocharc.yml
./.npmignore             .npmignore                  ProviderItem /Users/tyriar/dev/Tyriar/xterm.js/.npmignore
./.npmrc                 .npmrc                      ProviderItem /Users/tyriar/dev/Tyriar/xterm.js/.npmrc
./.nvmrc                 .nvmrc                      ProviderItem /Users/tyriar/dev/Tyriar/xterm.js/.nvmrc
./.vscode                .vscode                ProviderContainer /Users/tyriar/dev/Tyriar/xterm.js/.vscode

@Tyriar
Copy link
Member

Tyriar commented Jun 14, 2024

Looks promising 馃憖

Screenshot 2024-06-14 at 10 11 11鈥疉M

Tyriar added a commit that referenced this issue Jun 14, 2024
@Tyriar
Add . and .. to suggestions, do nothing is completing same
ce3f763 
Fixes #211996
@Tyriar Tyriar mentioned this issue Jun 14, 2024
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 17, 2024
@amunger amunger added the verified Verification succeeded label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders papercut 馃└ A particularly annoying issue impacting someone on the team terminal-suggest verified Verification succeeded
Projects
None yet
Milestone
June 2024
Development

Successfully merging a pull request may close this issue.

Add . and .. to suggestions, do nothing is completing same microsoft/vscode
3 participants
@amunger @Tyriar @VSCodeTriageBot