Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension asks for commenting ranges on a file that got deleted in PR #6046

Closed
bpasero opened this issue Jun 18, 2024 · 0 comments · Fixed by #6048
Closed

Extension asks for commenting ranges on a file that got deleted in PR #6046

bpasero opened this issue Jun 18, 2024 · 0 comments · Fixed by #6048
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 18, 2024

In microsoft/vscode#214588, a file workbench.desktop.nls.js is deleted, yet I see many errors printed for the extension asking to resolve comment ranges:

ExtHostDocuments.ensureDocumentData (/Users/bpasero/Development/Microsoft/vscode-electron-22.x/src/vs/workbench/api/common/extHostDocuments.ts:88)
<anonymous> (/Users/bpasero/Development/Microsoft/vscode-electron-22.x/src/vs/workbench/api/common/extHost.api.impl.ts:1047)
process.processTicksAndRejections (internal/process/task_queues:95)
Promise.then (Unknown Source:0)
openTextDocument (/Users/bpasero/Development/Microsoft/vscode-electron-22.x/src/vs/workbench/api/common/extHost.api.impl.ts:1043)
updateResourcesWithCommentingRanges (/Users/bpasero/.vscode-oss-dev/extensions/github.vscode-pull-request-github-0.89.2024053108/dist/extension.js:2044)
Vr (/Users/bpasero/.vscode-oss-dev/extensions/github.vscode-pull-request-github-0.89.2024053108/dist/extension.js:2044)
doRegisterCommentController (/Users/bpasero/.vscode-oss-dev/extensions/github.vscode-pull-request-github-0.89.2024053108/dist/extension.js:2069)
<anonymous> (/Users/bpasero/.vscode-oss-dev/extensions/github.vscode-pull-request-github-0.89.2024053108/dist/extension.js:2069)
_deliver (/Users/bpasero/Development/Microsoft/vscode-electron-22.x/src/vs/base/common/event.ts:1211)
fire (/Users/bpasero/Development/Microsoft/vscode-electron-22.x/src/vs/base/common/event.ts:1242)
set localFileChanges (/Users/bpasero/.vscode-oss-dev/extensions/github.vscode-pull-request-github-0.89.2024053108/dist/extension.js:2069)
initializePullRequestData (/Users/bpasero/.vscode-oss-dev/extensions/github.vscode-pull-request-github-0.89.2024053108/dist/extension.js:2069)
processTicksAndRejections (internal/process/task_queues:95)
await (Unknown Source:0)
processTicksAndRejections (internal/process/task_queues:95)
await (Unknown Source:0)
validateState (/Users/bpasero/.vscode-oss-dev/extensions/github.vscode-pull-request-github-0.89.2024053108/dist/extension.js:2069)
processTicksAndRejections (internal/process/task_queues:95)
await (Unknown Source:0)
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Jun 18, 2024
@alexr00 alexr00 added this to the June 2024 milestone Jun 18, 2024
@bpasero bpasero added the verified Verification succeeded label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
2 participants