Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flint] update to 3.1.3-p1 #39293

Open
tueda opened this issue Jun 14, 2024 · 6 comments
Open

[flint] update to 3.1.3-p1 #39293

tueda opened this issue Jun 14, 2024 · 6 comments
Assignees
Labels
category:port-update The issue is with a library, which is requesting update new revision

Comments

@tueda
Copy link
Contributor

tueda commented Jun 14, 2024

Library name

Flint

New version number

3.1.3-p1

Other information that may be useful (release notes, etc...)

https://github.com/flintlib/flint/releases/tag/v3.1.3-p1

@tueda tueda added the category:port-update The issue is with a library, which is requesting update new revision label Jun 14, 2024
@MonicaLiu0311
Copy link
Contributor

@fredrik-johansson @albinahlback
Just want to confirm with you, what is the relationship between v3.1.3-p1 and v3.1.3? Does "p1" mean patch1?

@albinahlback
Copy link

I never updated the version number when pushing the new patches. For instance, v3.1.3 claims that it is version v3.1.0. @edgarcosta realized this and patched this with v3.1.3-p1.

@MonicaLiu0311
Copy link
Contributor

I never updated the version number when pushing the new patches. For instance, v3.1.3 claims that it is version v3.1.0. @edgarcosta realized this and patched this with v3.1.3-p1.

OK, thanks for your reply.
So, does it mean that v3.1.3-p1 is the official release version of 3.1.3?
Will the official release version after it be v3.1.4 or v3.1.3-p2/v3.1.4-p1?

@albinahlback
Copy link

OK, thanks for your reply. So, does it mean that v3.1.3-p1 is the official release version of 3.1.3? Will the official release version after it be v3.1.4 or v3.1.3-p2/v3.1.4-p1?

It should be v.3.1.4 or v3.2.0 (i.e. no "-pX" suffix).

@MonicaLiu0311
Copy link
Contributor

@tueda
Can I update it to 3.1.2? If I update to 3.1.3-p1, the version field in vcpkg.json will change. 3.1.3-p1 must use the version-string field, and "version" and "version-string" cannot be compared. Moreover, 3.1.3-p1 is an accidental event and will not continue this version format in the future. We can update to 3.1.2 now, skip 3.1.3 and wait for the next official version directly.

@tueda
Copy link
Contributor Author

tueda commented Jun 17, 2024

@tueda Can I update it to 3.1.2?

I think this is sufficient for now, as the change from version 2.x to version 3.x seems more significant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

No branches or pull requests

3 participants