Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcpkg/scripts/test_ports/vcpkg-ci-openimageio/vcpkg.json is invalid #39276

Closed
Chu-4hun opened this issue Jun 13, 2024 · 1 comment · Fixed by #39285
Closed

vcpkg/scripts/test_ports/vcpkg-ci-openimageio/vcpkg.json is invalid #39276

Chu-4hun opened this issue Jun 13, 2024 · 1 comment · Fixed by #39285
Assignees
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)

Comments

@Chu-4hun
Copy link

Describe the bug
vcpkg.json file in vcpkg/scripts/test_ports/vcpkg-ci-openimageio missing , character

{
  "name": "vcpkg-ci-openimageio",
  "version": "1",
  "description": "OpenImageIO features testing within CI.",
  "license": "MIT",
  "dependencies": [
    {
      "name": "openimageio",
      "features": [
        "ffmpeg",
        "freetype",
        "gif",
        "libraw",
        "opencv",
        "openjpeg",
        {
          "name": "pybind11",
          "platform": "!(windows & static)"
        } <------- missing , here
        "tools",
        "webp"
      ]
    }
  ]
}

Environment

  • Any

To Reproduce
Steps to reproduce the behavior:
Open https://github.com/microsoft/vcpkg/blob/master/scripts/test_ports/vcpkg-ci-openimageio/vcpkg.json

Expected behavior
regular json array with ','

Failure logs

Parse error on line 19:
..."        }        "tools",        "we
---------------------^
Expecting 'EOF', '}', ',', ']', got 'STRING'

Additional context

@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Jun 14, 2024
@JonLiu1993 JonLiu1993 added category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) and removed category:port-bug The issue is with a library, which is something the port should already support labels Jun 14, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Jun 17, 2024

microsoft/vcpkg-tool#1435 should help to permanently prevent such problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants