Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to thrifty retrofit converter #148

Open
reisub opened this issue Jul 12, 2017 · 4 comments
Open

Link to thrifty retrofit converter #148

reisub opened this issue Jul 12, 2017 · 4 comments

Comments

@reisub
Copy link
Contributor

reisub commented Jul 12, 2017

Hi Thrifty developers,

thanks for the great lib!

I implemented a retrofit converter for thrifty, can you please take a look at this retrofit PR?

I would be glad to adjust the coding style and make a PR to Thrifty if it makes sense for you to have the converter as part of this repository.

Thanks in advance

@benjamin-bader
Copy link
Collaborator

This is pretty cool - nice work!

To mirror Jake's response to your PR, I also don't feel that we'd be good maintainers of this particular project - we don't use Thrift over HTTP at all, and almost certainly never will.

Would you be willing to publish this yourself? I'd be really happy to link to it.

@reisub
Copy link
Contributor Author

reisub commented Jul 18, 2017

Okay, thanks for the feedback.

The converter is now published here (we're just waiting for it to be linked to jcenter):
https://github.com/infinum/thrifty-retrofit-converter

Can you link to it?

@reisub reisub changed the title Thrifty Retrofit converter Link to thrifty retrofit converter Jul 18, 2017
@benjamin-bader
Copy link
Collaborator

That's great! I'll have a link up soon.

@reisub
Copy link
Contributor Author

reisub commented Jul 2, 2019

Hi @benjamin-bader, just a friendly reminder about this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants