Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add loading skeletons to the main nav #44010

Merged
merged 5 commits into from
Jun 19, 2024
Merged

feat: Add loading skeletons to the main nav #44010

merged 5 commits into from
Jun 19, 2024
+51 −21

Conversation

rafpaf
Copy link
Contributor

@rafpaf rafpaf commented Jun 11, 2024 •
edited
Loading

Adds loading skeletons to the nav

Kapture 2024-06-12 at 12 56 17

Closes #44262

This was referenced Jun 11, 2024
Merged
Merged
Merged
@rafpaf Graphite App
Copy link
Contributor Author

rafpaf commented Jun 11, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rafpaf and the rest of your teammates on Graphite Graphite

@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label Jun 11, 2024
@rafpaf rafpaf changed the title Add loading skeletons to nav Add skeletons to sidebar Jun 11, 2024
@rafpaf rafpaf mentioned this pull request Jun 11, 2024
Closed
@rafpaf rafpaf changed the title Add skeletons to sidebar (prototype) Add skeletons to sidebar Jun 11, 2024
@rafpaf rafpaf force-pushed the better-skeletons branch 4 times, most recently from 157905a to d1da60e Compare June 12, 2024 14:16
@rafpaf rafpaf changed the title (prototype) Add skeletons to sidebar Add skeletons to sidebar Jun 12, 2024
This was referenced Jun 13, 2024
Merged
Open
Merged
@mazameli
Copy link
Contributor

Shut up and take my money

@rafpaf rafpaf force-pushed the better-skeletons branch 2 times, most recently from 5de7883 to f962340 Compare June 13, 2024 20:48
Base automatically changed from better-skeletons to master June 14, 2024 00:33
@rafpaf rafpaf marked this pull request as ready for review June 14, 2024 02:35
@rafpaf rafpaf requested a review from a team June 14, 2024 02:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 14, 2024 •
edited
Loading

Codenotify: Notifying subscribers in CODENOTIFY files for diff 9333413...0350dfe.

Notify File(s)
@kdoh frontend/src/metabase/ui/components/feedback/Skeleton/Repeat.tsx

@graphite-app Graphite App
Copy link

graphite-app bot commented Jun 14, 2024

Graphite Automations

"Warn authors when publishing large PRs" took an action on this PR • (06/14/24)

1 teammate was notified to this PR based on Raphael Krut-Landau's automation.

@replay-io replay.io
Copy link

replay-io bot commented Jun 14, 2024 •
edited
Loading

Status In Progress ↗︎ 59 / 60
Commit 0350dfe
Results
⚠️ 1 Flaky
✅ 2635 Passed

@rafpaf rafpaf added the no-backport Do not backport this PR to any branch label Jun 14, 2024 — with Graphite App
@rafpaf rafpaf changed the title Add skeletons to sidebar feat: Add skeletons to sidebar Jun 15, 2024
@rafpaf rafpaf mentioned this pull request Jun 15, 2024
Merged
@rafpaf rafpaf changed the title feat: Add skeletons to sidebar feat: Add loading skeletons to sidebar Jun 15, 2024
@rafpaf rafpaf changed the title feat: Add loading skeletons to sidebar feat: Add loading skeletons to the main nav Jun 15, 2024
@rafpaf rafpaf merged commit c006657 into master Jun 19, 2024
111 checks passed
@rafpaf rafpaf deleted the nav-skeletons branch June 19, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloansparger sloansparger sloansparger approved these changes

Assignees

@rafpaf rafpaf

Labels
no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add skeletons to sidebar
3 participants
@rafpaf @mazameli @sloansparger